From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nyt3o-0002KY-Tx for qemu-devel@nongnu.org; Mon, 05 Apr 2010 16:38:16 -0400 Received: from [140.186.70.92] (port=49595 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nyt3m-0001qw-6f for qemu-devel@nongnu.org; Mon, 05 Apr 2010 16:38:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nyt0h-0001gW-8J for qemu-devel@nongnu.org; Mon, 05 Apr 2010 16:35:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:23604) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nyt0h-0001gJ-0V for qemu-devel@nongnu.org; Mon, 05 Apr 2010 16:35:03 -0400 From: Luiz Capitulino Date: Mon, 5 Apr 2010 17:34:02 -0300 Message-Id: <1270499642-31543-22-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1270499642-31543-1-git-send-email-lcapitulino@redhat.com> References: <1270499642-31543-1-git-send-email-lcapitulino@redhat.com> Subject: [Qemu-devel] [PATCH 21/21] Monitor: Convert do_screen_dump() to QObject List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: aliguori@us.ibm.com Cc: qemu-devel@nongnu.org, Luiz Capitulino Trivial, as it never fails, doesn't have output nor return any data. Note that it's also available under QMP, as kvm-autotest needs this. Signed-off-by: Luiz Capitulino --- monitor.c | 3 ++- qemu-monitor.hx | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/monitor.c b/monitor.c index c5a4dbf..709b326 100644 --- a/monitor.c +++ b/monitor.c @@ -1164,9 +1164,10 @@ static int do_change(Monitor *mon, const QDict *qdict, QObject **ret_data) return ret; } -static void do_screen_dump(Monitor *mon, const QDict *qdict) +static int do_screen_dump(Monitor *mon, const QDict *qdict, QObject **ret_data) { vga_hw_screen_dump(qdict_get_str(qdict, "filename")); + return 0; } static void do_logfile(Monitor *mon, const QDict *qdict) diff --git a/qemu-monitor.hx b/qemu-monitor.hx index 62fa346..5ea5748 100644 --- a/qemu-monitor.hx +++ b/qemu-monitor.hx @@ -199,7 +199,8 @@ ETEXI .args_type = "filename:F", .params = "filename", .help = "save screen into PPM image 'filename'", - .mhandler.cmd = do_screen_dump, + .user_print = monitor_user_noop, + .mhandler.cmd_new = do_screen_dump, }, STEXI -- 1.7.0.4.297.g6555b1