From: Alexander Graf <agraf@suse.de>
To: qemu-devel@nongnu.org
Cc: Amit Shah <amit.shah@redhat.com>,
Bastian Blank <bastian@waldi.eu.org>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: [Qemu-devel] [PATCH] [S390] Make virtio-pci building conditional again
Date: Tue, 6 Apr 2010 12:11:43 +0200 [thread overview]
Message-ID: <1270548703-28636-1-git-send-email-agraf@suse.de> (raw)
Commit b305b9d7d6990e492966ffb1fdf619482adeb7e2 made building of virtio-pci
conditional and not enabled on S390x, because it collides with the S390 bus.
Commit 087431d1d1bf4e785edfa89e8cd05fcdac558dc3 accidentially reverted that
behavior, breaking S390x again.
So here's a follow-up patch disabling building of virtio-pci on S390x again.
This unbreaks the S390x target.
Signed-off-by: Alexander Graf <agraf@suse.de>
---
Makefile.target | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/Makefile.target b/Makefile.target
index 45cbe56..2624b1d 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -164,7 +164,8 @@ ifdef CONFIG_SOFTMMU
obj-y = arch_init.o cpus.o monitor.o machine.o gdbstub.o vl.o
# virtio has to be here due to weird dependency between PCI and virtio-net.
# need to fix this properly
-obj-y += virtio-blk.o virtio-balloon.o virtio-net.o virtio-pci.o virtio-serial-bus.o
+obj-y += virtio-blk.o virtio-balloon.o virtio-net.o virtio-serial-bus.o
+obj-$(CONFIG_VIRTIO_PCI) += virtio-pci.o
obj-y += event_notifier.o
obj-y += vhost_net.o
obj-$(CONFIG_VHOST_NET) += vhost.o
--
1.6.0.2
next reply other threads:[~2010-04-06 10:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-06 10:11 Alexander Graf [this message]
2010-04-08 19:49 ` [Qemu-devel] [PATCH] [S390] Make virtio-pci building conditional again Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270548703-28636-1-git-send-email-agraf@suse.de \
--to=agraf@suse.de \
--cc=amit.shah@redhat.com \
--cc=aurelien@aurel32.net \
--cc=bastian@waldi.eu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).