From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NzZwU-0000Ma-9Z for qemu-devel@nongnu.org; Wed, 07 Apr 2010 14:25:34 -0400 Received: from [140.186.70.92] (port=43699 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NzZwP-0000Km-ED for qemu-devel@nongnu.org; Wed, 07 Apr 2010 14:25:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NzZwL-0003fa-D0 for qemu-devel@nongnu.org; Wed, 07 Apr 2010 14:25:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63930) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NzZwJ-0003em-Fu for qemu-devel@nongnu.org; Wed, 07 Apr 2010 14:25:24 -0400 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o37IPMnl021075 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 7 Apr 2010 14:25:22 -0400 From: Luiz Capitulino Date: Wed, 7 Apr 2010 15:25:08 -0300 Message-Id: <1270664710-3948-3-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1270664710-3948-1-git-send-email-lcapitulino@redhat.com> References: <1270664710-3948-1-git-send-email-lcapitulino@redhat.com> Subject: [Qemu-devel] [PATCH 2/4] QMP: Use QERR_QMP_BAD_INPUT_OBJECT_MEMBER List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: armbru@redhat.com The QERR_QMP_BAD_INPUT_OBJECT error is going to be used only for two problems: the input is not an object or the "execute" key is missing. Signed-off-by: Luiz Capitulino --- monitor.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/monitor.c b/monitor.c index 709b326..cd350d6 100644 --- a/monitor.c +++ b/monitor.c @@ -4489,7 +4489,7 @@ static void handle_qmp_command(JSONMessageParser *parser, QList *tokens) qerror_report(QERR_QMP_BAD_INPUT_OBJECT, "execute"); goto err_input; } else if (qobject_type(obj) != QTYPE_QSTRING) { - qerror_report(QERR_QMP_BAD_INPUT_OBJECT, "string"); + qerror_report(QERR_QMP_BAD_INPUT_OBJECT_MEMBER, "execute", "string"); goto err_input; } -- 1.7.0.4.297.g6555b1