From: Amit Shah <amit.shah@redhat.com>
To: qemu list <qemu-devel@nongnu.org>
Cc: Amit Shah <amit.shah@redhat.com>,
Paul Brook <paul@codesourcery.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Juan Quintela <quintela@redhat.com>
Subject: [Qemu-devel] [PATCH 2/8] virtio-serial: Unthrottle ports once they're closed
Date: Thu, 8 Apr 2010 02:32:30 +0530 [thread overview]
Message-ID: <1270674156-9345-3-git-send-email-amit.shah@redhat.com> (raw)
In-Reply-To: <1270674156-9345-2-git-send-email-amit.shah@redhat.com>
Disable throttling once a port is closed (and we discard all the
unconsumed buffers in the vq).
Signed-off-by: Amit Shah <amit.shah@redhat.com>
---
hw/virtio-serial-bus.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
index 5df9b6b..8d77c94 100644
--- a/hw/virtio-serial-bus.c
+++ b/hw/virtio-serial-bus.c
@@ -190,8 +190,9 @@ int virtio_serial_close(VirtIOSerialPort *port)
/*
* If there's any data the guest sent which the app didn't
- * consume, discard it.
+ * consume, reset the throttling flag and discard the data.
*/
+ port->throttled = false;
flush_queued_data(port, true);
return 0;
}
--
1.6.2.5
next prev parent reply other threads:[~2010-04-07 21:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-07 21:02 [Qemu-devel] [PATCH 0/8] (v2) chardev, virtio-console: flow control, error handling, fixes Amit Shah
2010-04-07 21:02 ` [Qemu-devel] [PATCH 1/8] virtio-serial: throttling: check for throttled status before sending any data Amit Shah
2010-04-07 21:02 ` Amit Shah [this message]
2010-04-07 21:02 ` [Qemu-devel] [PATCH 3/8] virtio-serial: Discard unconsumed data before sending port close event Amit Shah
2010-04-07 21:02 ` [Qemu-devel] [PATCH 4/8] virtio-serial: Bus info message for showing port's throttled status Amit Shah
2010-04-07 21:02 ` [Qemu-devel] [PATCH 5/8] char: Let writers know how much data was written in case of errors Amit Shah
2010-04-07 21:02 ` [Qemu-devel] [PATCH 6/8] char: unix: For files that are nonblocking, report -EAGAIN to calling functions Amit Shah
2010-04-07 21:02 ` [Qemu-devel] [PATCH 7/8] virtio-console: Factor out common init between console and generic ports Amit Shah
2010-04-07 21:02 ` [Qemu-devel] [PATCH 8/8] virtio-console: Throttle virtio-serial-bus if we can't consume any more guest data Amit Shah
2010-04-07 22:58 ` [Qemu-devel] Re: [PATCH 0/8] (v2) chardev, virtio-console: flow control, error handling, fixes Paul Brook
2010-04-12 7:51 ` Gerd Hoffmann
2010-04-12 11:42 ` Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270674156-9345-3-git-send-email-amit.shah@redhat.com \
--to=amit.shah@redhat.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).