From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NzcQG-00048p-FN for qemu-devel@nongnu.org; Wed, 07 Apr 2010 17:04:28 -0400 Received: from [140.186.70.92] (port=35122 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NzcQE-00047V-F1 for qemu-devel@nongnu.org; Wed, 07 Apr 2010 17:04:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NzcQA-0003Cl-OA for qemu-devel@nongnu.org; Wed, 07 Apr 2010 17:04:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32129) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NzcQA-0003Ch-Gx for qemu-devel@nongnu.org; Wed, 07 Apr 2010 17:04:22 -0400 From: Amit Shah Date: Thu, 8 Apr 2010 02:32:31 +0530 Message-Id: <1270674156-9345-4-git-send-email-amit.shah@redhat.com> In-Reply-To: <1270674156-9345-3-git-send-email-amit.shah@redhat.com> References: <1270674156-9345-1-git-send-email-amit.shah@redhat.com> <1270674156-9345-2-git-send-email-amit.shah@redhat.com> <1270674156-9345-3-git-send-email-amit.shah@redhat.com> Subject: [Qemu-devel] [PATCH 3/8] virtio-serial: Discard unconsumed data before sending port close event List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu list Cc: Amit Shah , Paul Brook , "Michael S. Tsirkin" , Gerd Hoffmann , Juan Quintela The guest kernel can reclaim the buffers when it receives the port close event or when a port is being removed. Ensure we free up the buffers before we send out any events to the guest. Signed-off-by: Amit Shah --- hw/virtio-serial-bus.c | 13 +++++++++---- 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c index 8d77c94..c0044b3 100644 --- a/hw/virtio-serial-bus.c +++ b/hw/virtio-serial-bus.c @@ -186,14 +186,15 @@ int virtio_serial_open(VirtIOSerialPort *port) int virtio_serial_close(VirtIOSerialPort *port) { port->host_connected = false; - send_control_event(port, VIRTIO_CONSOLE_PORT_OPEN, 0); - /* * If there's any data the guest sent which the app didn't * consume, reset the throttling flag and discard the data. */ port->throttled = false; flush_queued_data(port, true); + + send_control_event(port, VIRTIO_CONSOLE_PORT_OPEN, 0); + return 0; } @@ -631,13 +632,17 @@ static void add_port(VirtIOSerial *vser, uint32_t port_id) static void remove_port(VirtIOSerial *vser, uint32_t port_id) { + VirtIOSerialPort *port; unsigned int i; i = port_id / 32; vser->ports_map[i] &= ~(1U << (port_id % 32)); - send_control_event(find_port_by_id(vser, port_id), - VIRTIO_CONSOLE_PORT_REMOVE, 1); + port = find_port_by_id(vser, port_id); + /* Flush out any unconsumed buffers first */ + flush_queued_data(port, true); + + send_control_event(port, VIRTIO_CONSOLE_PORT_REMOVE, 1); } static int virtser_port_qdev_init(DeviceState *qdev, DeviceInfo *base) -- 1.6.2.5