From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O1vBb-0002GI-2r for qemu-devel@nongnu.org; Wed, 14 Apr 2010 01:30:51 -0400 Received: from [140.186.70.92] (port=49020 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O1vBZ-0002Fh-EQ for qemu-devel@nongnu.org; Wed, 14 Apr 2010 01:30:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O1vBX-0005zn-RC for qemu-devel@nongnu.org; Wed, 14 Apr 2010 01:30:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21011) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O1vBX-0005zi-I8 for qemu-devel@nongnu.org; Wed, 14 Apr 2010 01:30:47 -0400 From: Amit Shah Date: Wed, 14 Apr 2010 10:58:27 +0530 Message-Id: <1271222917-7803-8-git-send-email-amit.shah@redhat.com> In-Reply-To: <1271222917-7803-7-git-send-email-amit.shah@redhat.com> References: <1271222917-7803-1-git-send-email-amit.shah@redhat.com> <1271222917-7803-2-git-send-email-amit.shah@redhat.com> <1271222917-7803-3-git-send-email-amit.shah@redhat.com> <1271222917-7803-4-git-send-email-amit.shah@redhat.com> <1271222917-7803-5-git-send-email-amit.shah@redhat.com> <1271222917-7803-6-git-send-email-amit.shah@redhat.com> <1271222917-7803-7-git-send-email-amit.shah@redhat.com> Subject: [Qemu-devel] [PATCH v5 07/17] virtio-serial: Remove redundant check for 0-sized write request List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu list , Amit Shah , Gerd Hoffmann , Juan Quintela The check for a 0-sized write request to a guest port is not necessary; the while loop below won't be executed in this case and all will be fine. Signed-off-by: Amit Shah --- hw/virtio-serial-bus.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c index 8efba0b..c1d9851 100644 --- a/hw/virtio-serial-bus.c +++ b/hw/virtio-serial-bus.c @@ -91,9 +91,6 @@ static size_t write_to_port(VirtIOSerialPort *port, if (!virtio_queue_ready(vq)) { return 0; } - if (!size) { - return 0; - } while (offset < size) { int i; -- 1.6.2.5