From: Amit Shah <amit.shah@redhat.com>
To: qemu list <qemu-devel@nongnu.org>
Cc: Amit Shah <amit.shah@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>,
paul@codesourcery.com
Subject: [Qemu-devel] [PATCH v3 1/4] char: Let writers know how much data was written in case of errors
Date: Thu, 15 Apr 2010 13:46:15 +0530 [thread overview]
Message-ID: <1271319378-9811-2-git-send-email-amit.shah@redhat.com> (raw)
In-Reply-To: <1271319378-9811-1-git-send-email-amit.shah@redhat.com>
On writing errors, we just returned -1 even if some bytes were already
written out. Ensure we return the number of bytes written before we
return the error (on a subsequent call to qemu_chr_write()).
Signed-off-by: Amit Shah <amit.shah@redhat.com>
---
qemu-char.c | 9 +++++++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 05df971..6aaa362 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -522,8 +522,13 @@ static int unix_write(int fd, const uint8_t *buf, int len1)
while (len > 0) {
ret = write(fd, buf, len);
if (ret < 0) {
- if (errno != EINTR && errno != EAGAIN)
- return -1;
+ if (errno != EINTR && errno != EAGAIN) {
+ if (len1 - len) {
+ return len1 - len;
+ } else {
+ return -1;
+ }
+ }
} else if (ret == 0) {
break;
} else {
--
1.6.2.5
next prev parent reply other threads:[~2010-04-15 8:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-15 8:16 [Qemu-devel] [PATCH v3 0/4] char: write callback, virtio-console: flow control Amit Shah
2010-04-15 8:16 ` Amit Shah [this message]
2010-04-15 8:16 ` [Qemu-devel] [PATCH v3 2/4] char: Add ability to provide a callback when write won't return -EAGAIN Amit Shah
2010-04-15 8:16 ` [Qemu-devel] [PATCH v3 3/4] virtio-console: Factor out common init between console and generic ports Amit Shah
2010-04-15 8:16 ` [Qemu-devel] [PATCH v3 4/4] virtio-console: Throttle virtio-serial-bus if we can't consume any more guest data Amit Shah
2010-04-20 11:32 ` [Qemu-devel] [PATCH v3 2/4] char: Add ability to provide a callback when write won't return -EAGAIN Gerd Hoffmann
2010-04-20 11:44 ` Amit Shah
2010-04-20 12:28 ` Paul Brook
2010-04-20 12:39 ` Amit Shah
2010-04-20 18:59 ` Gerd Hoffmann
2010-04-15 12:04 ` [Qemu-devel] [PATCH v3 0/4] char: write callback, virtio-console: flow control Paul Brook
2010-04-15 12:58 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1271319378-9811-2-git-send-email-amit.shah@redhat.com \
--to=amit.shah@redhat.com \
--cc=kraxel@redhat.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).