From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O2Oqb-00070n-PH for qemu-devel@nongnu.org; Thu, 15 Apr 2010 09:11:09 -0400 Received: from [140.186.70.92] (port=58872 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O2OqX-0006vz-6Q for qemu-devel@nongnu.org; Thu, 15 Apr 2010 09:11:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O2OqV-00078R-9K for qemu-devel@nongnu.org; Thu, 15 Apr 2010 09:11:04 -0400 Received: from mtagate3.uk.ibm.com ([194.196.100.163]:55646) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O2OqV-00078D-0o for qemu-devel@nongnu.org; Thu, 15 Apr 2010 09:11:03 -0400 Received: from d06nrmr1806.portsmouth.uk.ibm.com (d06nrmr1806.portsmouth.uk.ibm.com [9.149.39.193]) by mtagate3.uk.ibm.com (8.13.1/8.13.1) with ESMTP id o3FDB1fq004347 for ; Thu, 15 Apr 2010 13:11:01 GMT Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com [9.149.37.212]) by d06nrmr1806.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o3FDB0h31388724 for ; Thu, 15 Apr 2010 14:11:00 +0100 Received: from d06av01.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av01.portsmouth.uk.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id o3FDB0ce023008 for ; Thu, 15 Apr 2010 14:11:00 +0100 From: Stefan Hajnoczi Date: Thu, 15 Apr 2010 14:11:35 +0100 Message-Id: <1271337095-4727-1-git-send-email-stefanha@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH] qcow2: Use QLIST_FOREACH_SAFE macro List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi --- block/qcow2.c | 10 ++-------- 1 files changed, 2 insertions(+), 8 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 11ce8d1..9b986ae 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -539,14 +539,8 @@ static void run_dependent_requests(QCowL2Meta *m) QLIST_REMOVE(m, next_in_flight); } - /* - * Restart all dependent requests. - * Can't use QLIST_FOREACH here - the next link might not be the same - * any more after the callback (request could depend on a different - * request now) - */ - for (req = m->dependent_requests.lh_first; req != NULL; req = next) { - next = req->next_depend.le_next; + /* Restart all dependent requests */ + QLIST_FOREACH_SAFE(req, &m->dependent_requests, next_depend, next) { qcow_aio_write_cb(req, 0); } -- 1.7.0