From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O4KiU-0007Mc-5b for qemu-devel@nongnu.org; Tue, 20 Apr 2010 17:10:46 -0400 Received: from [140.186.70.92] (port=37514 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O4KiM-0007Ir-Tm for qemu-devel@nongnu.org; Tue, 20 Apr 2010 17:10:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O4KiI-00041q-UC for qemu-devel@nongnu.org; Tue, 20 Apr 2010 17:10:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61609) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O4KiI-00041h-KL for qemu-devel@nongnu.org; Tue, 20 Apr 2010 17:10:34 -0400 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3KLAXuO019543 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 20 Apr 2010 17:10:34 -0400 From: Luiz Capitulino Date: Tue, 20 Apr 2010 18:09:46 -0300 Message-Id: <1271797792-24571-17-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1271797792-24571-1-git-send-email-lcapitulino@redhat.com> References: <1271797792-24571-1-git-send-email-lcapitulino@redhat.com> Subject: [Qemu-devel] [PATCH 16/22] savevm: Convert delete_snapshot() to QError List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, armbru@redhat.com, quintela@redhat.com, kwolf@redhat.com Signed-off-by: Luiz Capitulino --- savevm.c | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/savevm.c b/savevm.c index 3ccb246..55cf848 100644 --- a/savevm.c +++ b/savevm.c @@ -1628,12 +1628,11 @@ static int delete_snapshot(Monitor *mon, BlockDriverState *bs, if (ret < 0) { switch (ret) { case -ENOTSUP: - monitor_printf(mon, "Snapshots not supported on device '%s'\n", - bdrv_get_device_name(bs)); + qerror_report(QERR_DEVICE_NO_SNAPSHOT, bdrv_get_device_name(bs)); break; default: - monitor_printf(mon, "Error %d while deleting snapshot on '%s'\n", - ret, bdrv_get_device_name(bs)); + qerror_report(QERR_SNAPSHOT_DELETE_FAILED, bdrv_get_device_name(bs), + get_errno_string(ret)); break; } } -- 1.7.1.rc1.12.ga6018