From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O4KiT-0007M8-13 for qemu-devel@nongnu.org; Tue, 20 Apr 2010 17:10:45 -0400 Received: from [140.186.70.92] (port=37558 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O4KiR-0007LR-PR for qemu-devel@nongnu.org; Tue, 20 Apr 2010 17:10:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O4KiP-00043B-VS for qemu-devel@nongnu.org; Tue, 20 Apr 2010 17:10:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47244) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O4KiO-00042y-SL for qemu-devel@nongnu.org; Tue, 20 Apr 2010 17:10:41 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3KLAeDn019192 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 20 Apr 2010 17:10:40 -0400 From: Luiz Capitulino Date: Tue, 20 Apr 2010 18:09:49 -0300 Message-Id: <1271797792-24571-20-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1271797792-24571-1-git-send-email-lcapitulino@redhat.com> References: <1271797792-24571-1-git-send-email-lcapitulino@redhat.com> Subject: [Qemu-devel] [PATCH 19/22] savevm: Convert do_savevm() to QError List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, armbru@redhat.com, quintela@redhat.com, kwolf@redhat.com Signed-off-by: Luiz Capitulino --- savevm.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/savevm.c b/savevm.c index 031eeff..8a9e9d1 100644 --- a/savevm.c +++ b/savevm.c @@ -1682,7 +1682,7 @@ void do_savevm(Monitor *mon, const QDict *qdict) bs = get_bs_snapshots(); if (!bs) { - monitor_printf(mon, "No block device can accept snapshots\n"); + qerror_report(QERR_SNAPSHOT_NO_DEVICE); return; } @@ -1726,7 +1726,7 @@ void do_savevm(Monitor *mon, const QDict *qdict) vm_state_size = qemu_ftell(f); qemu_fclose(f); if (ret < 0) { - monitor_printf(mon, "Error %d while writing VM\n", ret); + qerror_report(QERR_STATEVM_SAVE_FAILED, get_errno_string(ret)); goto the_end; } @@ -1739,8 +1739,8 @@ void do_savevm(Monitor *mon, const QDict *qdict) sn->vm_state_size = (bs == bs1 ? vm_state_size : 0); ret = bdrv_snapshot_create(bs1, sn); if (ret < 0) { - monitor_printf(mon, "Error while creating snapshot on '%s'\n", - bdrv_get_device_name(bs1)); + qerror_report(QERR_SNAPSHOT_CREATE_FAILED, + bdrv_get_device_name(bs1), get_errno_string(ret)); } } } -- 1.7.1.rc1.12.ga6018