From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O5KrP-0007WK-1D for qemu-devel@nongnu.org; Fri, 23 Apr 2010 11:32:07 -0400 Received: from [140.186.70.92] (port=50391 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O5KrL-0007Tj-Vq for qemu-devel@nongnu.org; Fri, 23 Apr 2010 11:32:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O5KrJ-0005up-5G for qemu-devel@nongnu.org; Fri, 23 Apr 2010 11:32:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1865) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O5KrI-0005uf-NM for qemu-devel@nongnu.org; Fri, 23 Apr 2010 11:32:01 -0400 From: Kevin Wolf Date: Fri, 23 Apr 2010 17:30:45 +0200 Message-Id: <1272036658-26776-14-git-send-email-kwolf@redhat.com> In-Reply-To: <1272036658-26776-1-git-send-email-kwolf@redhat.com> References: <1272036658-26776-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 13/26] qcow2: Fix error return code in qcow2_alloc_cluster_link_l2 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: aliguori@linux.vnet.ibm.com Cc: kwolf@redhat.com, qemu-devel@nongnu.org Fix qcow2_alloc_cluster_link_l2 to return the real error code like it does in all other error cases. Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index 2f37acd..d2774d1 100644 --- a/block/qcow2-cluster.c +++ b/block/qcow2-cluster.c @@ -687,8 +687,8 @@ int qcow2_alloc_cluster_link_l2(BlockDriverState *bs, QCowL2Meta *m) (i << s->cluster_bits)) | QCOW_OFLAG_COPIED); } - if (write_l2_entries(s, l2_table, l2_offset, l2_index, m->nb_clusters) < 0) { - ret = -1; + ret = write_l2_entries(s, l2_table, l2_offset, l2_index, m->nb_clusters); + if (ret < 0) { goto err; } -- 1.6.6.1