From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O5Krf-0007i8-JW for qemu-devel@nongnu.org; Fri, 23 Apr 2010 11:32:23 -0400 Received: from [140.186.70.92] (port=50538 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O5Kra-0007fO-V3 for qemu-devel@nongnu.org; Fri, 23 Apr 2010 11:32:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O5KrX-0005yz-GR for qemu-devel@nongnu.org; Fri, 23 Apr 2010 11:32:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64364) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O5KrX-0005yp-93 for qemu-devel@nongnu.org; Fri, 23 Apr 2010 11:32:15 -0400 From: Kevin Wolf Date: Fri, 23 Apr 2010 17:30:51 +0200 Message-Id: <1272036658-26776-20-git-send-email-kwolf@redhat.com> In-Reply-To: <1272036658-26776-1-git-send-email-kwolf@redhat.com> References: <1272036658-26776-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 19/26] Remove un-needed code List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: aliguori@linux.vnet.ibm.com Cc: kwolf@redhat.com, qemu-devel@nongnu.org From: Bruce Rogers The bdrv_set_geometry_hint call below is not needed - it's just setting what was just read. Signed-off-by: Bruce Rogers Signed-off-by: Kevin Wolf --- hw/virtio-blk.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index 01d77b8..b05d15e 100644 --- a/hw/virtio-blk.c +++ b/hw/virtio-blk.c @@ -494,7 +494,6 @@ VirtIODevice *virtio_blk_init(DeviceState *dev, BlockConf *conf) s->rq = NULL; s->sector_mask = (s->conf->logical_block_size / 512) - 1; bdrv_guess_geometry(s->bs, &cylinders, &heads, &secs); - bdrv_set_geometry_hint(s->bs, cylinders, heads, secs); s->vq = virtio_add_queue(&s->vdev, 128, virtio_blk_handle_output); -- 1.6.6.1