From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O5Krn-0007oM-PC for qemu-devel@nongnu.org; Fri, 23 Apr 2010 11:32:31 -0400 Received: from [140.186.70.92] (port=50617 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O5Krm-0007nA-DM for qemu-devel@nongnu.org; Fri, 23 Apr 2010 11:32:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O5Krk-00061c-Nm for qemu-devel@nongnu.org; Fri, 23 Apr 2010 11:32:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44974) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O5Krj-00061N-Sg for qemu-devel@nongnu.org; Fri, 23 Apr 2010 11:32:28 -0400 From: Kevin Wolf Date: Fri, 23 Apr 2010 17:30:57 +0200 Message-Id: <1272036658-26776-26-git-send-email-kwolf@redhat.com> In-Reply-To: <1272036658-26776-1-git-send-email-kwolf@redhat.com> References: <1272036658-26776-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 25/26] qcow2: Use QLIST_FOREACH_SAFE macro List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: aliguori@linux.vnet.ibm.com Cc: kwolf@redhat.com, qemu-devel@nongnu.org From: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block/qcow2.c | 10 ++-------- 1 files changed, 2 insertions(+), 8 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 30ded6a..f3e3cba 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -539,14 +539,8 @@ static void run_dependent_requests(QCowL2Meta *m) QLIST_REMOVE(m, next_in_flight); } - /* - * Restart all dependent requests. - * Can't use QLIST_FOREACH here - the next link might not be the same - * any more after the callback (request could depend on a different - * request now) - */ - for (req = m->dependent_requests.lh_first; req != NULL; req = next) { - next = req->next_depend.le_next; + /* Restart all dependent requests */ + QLIST_FOREACH_SAFE(req, &m->dependent_requests, next_depend, next) { qcow_aio_write_cb(req, 0); } -- 1.6.6.1