From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O6k1b-00065e-CV for qemu-devel@nongnu.org; Tue, 27 Apr 2010 08:36:27 -0400 Received: from [140.186.70.92] (port=51358 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O6k1W-00063W-Vc for qemu-devel@nongnu.org; Tue, 27 Apr 2010 08:36:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O6k1S-0002mz-DF for qemu-devel@nongnu.org; Tue, 27 Apr 2010 08:36:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1163) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O6k1S-0002mo-52 for qemu-devel@nongnu.org; Tue, 27 Apr 2010 08:36:18 -0400 From: Amit Shah Date: Tue, 27 Apr 2010 18:04:03 +0530 Message-Id: <1272371652-23087-10-git-send-email-amit.shah@redhat.com> In-Reply-To: <1272371652-23087-9-git-send-email-amit.shah@redhat.com> References: <1272371652-23087-1-git-send-email-amit.shah@redhat.com> <1272371652-23087-2-git-send-email-amit.shah@redhat.com> <1272371652-23087-3-git-send-email-amit.shah@redhat.com> <1272371652-23087-4-git-send-email-amit.shah@redhat.com> <1272371652-23087-5-git-send-email-amit.shah@redhat.com> <1272371652-23087-6-git-send-email-amit.shah@redhat.com> <1272371652-23087-7-git-send-email-amit.shah@redhat.com> <1272371652-23087-8-git-send-email-amit.shah@redhat.com> <1272371652-23087-9-git-send-email-amit.shah@redhat.com> Subject: [Qemu-devel] [PATCH v6 09/18] virtio-serial: Propagate errors in initialising ports / devices in guest List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Amit Shah , qemu list , Juan Quintela If adding of ports or devices in the guest fails we can send out a QMP event so that management software can deal with it. Signed-off-by: Amit Shah --- hw/virtio-serial-bus.c | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c index c77ea4f..3a09f0d 100644 --- a/hw/virtio-serial-bus.c +++ b/hw/virtio-serial-bus.c @@ -223,6 +223,11 @@ static void handle_control_message(VirtIOSerial *vser, void *buf) switch(cpkt.event) { case VIRTIO_CONSOLE_DEVICE_READY: + if (!cpkt.value) { + error_report("virtio-serial-bus: Guest failure in adding device %s\n", + vser->bus->qbus.name); + break; + } /* * The device is up, we can now tell the device about all the * ports we have here. @@ -233,6 +238,11 @@ static void handle_control_message(VirtIOSerial *vser, void *buf) break; case VIRTIO_CONSOLE_PORT_READY: + if (!cpkt.value) { + error_report("virtio-serial-bus: Guest failure in adding port %u for device %s\n", + port->id, vser->bus->qbus.name); + break; + } /* * Now that we know the guest asked for the port name, we're * sure the guest has initialised whatever state is necessary -- 1.6.2.5