qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
	qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/2] block: make .bdrv_create() a coroutine_fn
Date: Wed, 5 Jul 2017 06:26:05 -0400 (EDT)	[thread overview]
Message-ID: <1272552299.46884872.1499250365562.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20170705102231.20711-1-stefanha@redhat.com>



----- Original Message -----
> The BlockDriver->bdrv_create() function is always called from coroutine
> context.  These patches rename it and clean up qcow2 code that is currently
> calling CoMutex functions outside coroutine_fn.
> 
> Stefan Hajnoczi (2):
>   block: rename .bdrv_create() to .bdrv_co_create()
>   qcow2: make qcow2_co_create2() a coroutine_fn
> 

I came to the same changes with my series, so
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

>  include/block/block_int.h |  3 ++-
>  block.c                   |  4 ++--
>  block/crypto.c            |  8 ++++----
>  block/file-posix.c        | 15 ++++++++-------
>  block/file-win32.c        |  3 ++-
>  block/gluster.c           | 12 ++++++------
>  block/iscsi.c             |  7 ++++---
>  block/nfs.c               |  5 +++--
>  block/parallels.c         |  6 ++++--
>  block/qcow.c              |  5 +++--
>  block/qcow2.c             | 22 ++++++++++++----------
>  block/qed.c               |  6 ++++--
>  block/raw-format.c        |  5 +++--
>  block/rbd.c               |  6 ++++--
>  block/sheepdog.c          | 10 +++++-----
>  block/ssh.c               |  5 +++--
>  block/vdi.c               |  5 +++--
>  block/vhdx.c              |  5 +++--
>  block/vmdk.c              |  5 +++--
>  block/vpc.c               |  5 +++--
>  20 files changed, 81 insertions(+), 61 deletions(-)
> 
> --
> 2.9.4
> 
> 

  parent reply	other threads:[~2017-07-05 10:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-05 10:22 [Qemu-devel] [PATCH 0/2] block: make .bdrv_create() a coroutine_fn Stefan Hajnoczi
2017-07-05 10:22 ` [Qemu-devel] [PATCH 1/2] block: rename .bdrv_create() to .bdrv_co_create() Stefan Hajnoczi
2017-07-11  9:46   ` Kevin Wolf
2017-07-05 10:22 ` [Qemu-devel] [PATCH 2/2] qcow2: make qcow2_co_create2() a coroutine_fn Stefan Hajnoczi
2017-07-11  9:49   ` Kevin Wolf
2017-07-05 10:26 ` Marc-André Lureau [this message]
2017-07-11 10:09   ` [Qemu-devel] [Qemu-block] [PATCH 0/2] block: make .bdrv_create() " Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1272552299.46884872.1499250365562.JavaMail.zimbra@redhat.com \
    --to=marcandre.lureau@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).