From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O7qnH-0007Sm-TR for qemu-devel@nongnu.org; Fri, 30 Apr 2010 10:02:16 -0400 Received: from [140.186.70.92] (port=55199 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O7qnF-0007QB-CN for qemu-devel@nongnu.org; Fri, 30 Apr 2010 10:02:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O7qnD-0000RT-Mo for qemu-devel@nongnu.org; Fri, 30 Apr 2010 10:02:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8447) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O7qnD-0000RE-F4 for qemu-devel@nongnu.org; Fri, 30 Apr 2010 10:02:11 -0400 From: Kevin Wolf Date: Fri, 30 Apr 2010 16:00:31 +0200 Message-Id: <1272636040-17374-10-git-send-email-kwolf@redhat.com> In-Reply-To: <1272636040-17374-1-git-send-email-kwolf@redhat.com> References: <1272636040-17374-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 09/18] block: Set backing_hd to NULL after deleting it List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: aliguori@linux.vnet.ibm.com Cc: kwolf@redhat.com, qemu-devel@nongnu.org From: Stefan Hajnoczi It is safer to set backing_hd to NULL after deleting it so that any use after deletion is obvious during development. Happy segfaulting! This patch should be applied after Kevin Wolf's "vmdk: Convert to bdrv_open" so that vmdk does not segfault on close. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/block.c b/block.c index 56835af..b318355 100644 --- a/block.c +++ b/block.c @@ -589,8 +589,10 @@ unlink_and_fail: void bdrv_close(BlockDriverState *bs) { if (bs->drv) { - if (bs->backing_hd) + if (bs->backing_hd) { bdrv_delete(bs->backing_hd); + bs->backing_hd = NULL; + } bs->drv->bdrv_close(bs); qemu_free(bs->opaque); #ifdef _WIN32 -- 1.6.6.1