qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com
Subject: [Qemu-devel] [PATCH] vdi: Fix image creation
Date: Thu,  6 May 2010 14:55:59 +0200	[thread overview]
Message-ID: <1273150559-1587-1-git-send-email-kwolf@redhat.com> (raw)

The number of blocks needs to be rounded up to cover all of the virtual hard
disk. Without this fix, we can't even open our own images if their size is not
a multiple of the block size.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block/vdi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/block/vdi.c b/block/vdi.c
index 2b4d2c2..b990bbc 100644
--- a/block/vdi.c
+++ b/block/vdi.c
@@ -827,7 +827,7 @@ static int vdi_create(const char *filename, QEMUOptionParameter *options)
         return -errno;
     }
 
-    blocks = bytes / block_size;
+    blocks = (bytes + block_size - 1) / block_size;
     bmap_size = blocks * sizeof(uint32_t);
     bmap_size = ((bmap_size + SECTOR_SIZE - 1) & ~(SECTOR_SIZE -1));
 
-- 
1.6.6.1

             reply	other threads:[~2010-05-06 12:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-06 12:55 Kevin Wolf [this message]
2010-05-06 18:05 ` [Qemu-devel] Re: [PATCH] vdi: Fix image creation Stefan Weil
2010-05-06 18:29   ` [Qemu-devel] [PATCH] vdi: Fix image opening and creation for odd disk sizes Stefan Weil
2010-05-07  7:55     ` [Qemu-devel] " Kevin Wolf
2010-05-07 11:55       ` François Revol
2010-05-09 10:17         ` Stefan Weil
2010-05-10  7:47           ` Kevin Wolf
2010-05-10 20:12             ` [Qemu-devel] " Stefan Weil
2010-05-10 20:44               ` [Qemu-devel] " François Revol
2010-05-11  7:52               ` Kevin Wolf
2010-05-12 18:25                 ` [Qemu-devel] [PATCH] block/vdi: " Stefan Weil
2010-05-12 18:56                   ` [Qemu-devel] " Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1273150559-1587-1-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).