* [Qemu-devel] [PATCH] mips-dis: Add missing static attributes
@ 2010-05-06 20:18 Stefan Weil
2010-05-07 16:33 ` Blue Swirl
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Weil @ 2010-05-06 20:18 UTC (permalink / raw)
To: QEMU Developers
mips_abi_choices and mips_arch_choices are only used locally.
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
mips-dis.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/mips-dis.c b/mips-dis.c
index 56bffe5..4623a1c 100644
--- a/mips-dis.c
+++ b/mips-dis.c
@@ -3035,7 +3035,7 @@ struct mips_abi_choice
const char * const *fpr_names;
};
-struct mips_abi_choice mips_abi_choices[] =
+static struct mips_abi_choice mips_abi_choices[] =
{
{ "numeric", mips_gpr_names_numeric, mips_fpr_names_numeric },
{ "32", mips_gpr_names_oldabi, mips_fpr_names_32 },
@@ -3086,7 +3086,7 @@ struct mips_arch_choice
//~ #define ARRAY_SIZE(a) (sizeof(a) / sizeof(a[0]))
-const struct mips_arch_choice mips_arch_choices[] =
+static const struct mips_arch_choice mips_arch_choices[] =
{
{ "numeric", 0, 0, 0, 0,
mips_cp0_names_numeric, NULL, 0, mips_hwr_names_numeric },
--
1.7.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] mips-dis: Add missing static attributes
2010-05-06 20:18 [Qemu-devel] [PATCH] mips-dis: Add missing static attributes Stefan Weil
@ 2010-05-07 16:33 ` Blue Swirl
2010-05-07 21:20 ` Stefan Weil
0 siblings, 1 reply; 4+ messages in thread
From: Blue Swirl @ 2010-05-07 16:33 UTC (permalink / raw)
To: Stefan Weil; +Cc: QEMU Developers
On 5/6/10, Stefan Weil <weil@mail.berlios.de> wrote:
> mips_abi_choices and mips_arch_choices are only used locally.
>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
> mips-dis.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mips-dis.c b/mips-dis.c
> index 56bffe5..4623a1c 100644
> --- a/mips-dis.c
> +++ b/mips-dis.c
> @@ -3035,7 +3035,7 @@ struct mips_abi_choice
> const char * const *fpr_names;
> };
>
> -struct mips_abi_choice mips_abi_choices[] =
> +static struct mips_abi_choice mips_abi_choices[] =
> {
> { "numeric", mips_gpr_names_numeric, mips_fpr_names_numeric },
> { "32", mips_gpr_names_oldabi, mips_fpr_names_32 },
> @@ -3086,7 +3086,7 @@ struct mips_arch_choice
>
> //~ #define ARRAY_SIZE(a) (sizeof(a) / sizeof(a[0]))
The patch does not apply because the line above does not match HEAD.
> -const struct mips_arch_choice mips_arch_choices[] =
> +static const struct mips_arch_choice mips_arch_choices[] =
> {
> { "numeric", 0, 0, 0, 0,
> mips_cp0_names_numeric, NULL, 0, mips_hwr_names_numeric },
>
> --
> 1.7.0
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* [Qemu-devel] [PATCH] mips-dis: Add missing static attributes
2010-05-07 16:33 ` Blue Swirl
@ 2010-05-07 21:20 ` Stefan Weil
2010-05-09 7:03 ` [Qemu-devel] " Blue Swirl
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Weil @ 2010-05-07 21:20 UTC (permalink / raw)
To: QEMU Developers; +Cc: blauwirbel
mips_abi_choices and mips_arch_choices are only used locally.
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
mips-dis.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/mips-dis.c b/mips-dis.c
index 169169c..ae64543 100644
--- a/mips-dis.c
+++ b/mips-dis.c
@@ -3035,7 +3035,7 @@ struct mips_abi_choice
const char * const *fpr_names;
};
-struct mips_abi_choice mips_abi_choices[] =
+static struct mips_abi_choice mips_abi_choices[] =
{
{ "numeric", mips_gpr_names_numeric, mips_fpr_names_numeric },
{ "32", mips_gpr_names_oldabi, mips_fpr_names_32 },
@@ -3086,7 +3086,7 @@ struct mips_arch_choice
#define ARRAY_SIZE(a) (sizeof(a) / sizeof(a[0]))
-const struct mips_arch_choice mips_arch_choices[] =
+static const struct mips_arch_choice mips_arch_choices[] =
{
{ "numeric", 0, 0, 0, 0,
mips_cp0_names_numeric, NULL, 0, mips_hwr_names_numeric },
--
1.7.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Qemu-devel] Re: [PATCH] mips-dis: Add missing static attributes
2010-05-07 21:20 ` Stefan Weil
@ 2010-05-09 7:03 ` Blue Swirl
0 siblings, 0 replies; 4+ messages in thread
From: Blue Swirl @ 2010-05-09 7:03 UTC (permalink / raw)
To: Stefan Weil; +Cc: QEMU Developers
Thanks, applied.
On 5/8/10, Stefan Weil <weil@mail.berlios.de> wrote:
> mips_abi_choices and mips_arch_choices are only used locally.
>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
> mips-dis.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mips-dis.c b/mips-dis.c
>
> index 169169c..ae64543 100644
>
> --- a/mips-dis.c
> +++ b/mips-dis.c
> @@ -3035,7 +3035,7 @@ struct mips_abi_choice
> const char * const *fpr_names;
> };
>
> -struct mips_abi_choice mips_abi_choices[] =
> +static struct mips_abi_choice mips_abi_choices[] =
> {
> { "numeric", mips_gpr_names_numeric, mips_fpr_names_numeric },
> { "32", mips_gpr_names_oldabi, mips_fpr_names_32 },
> @@ -3086,7 +3086,7 @@ struct mips_arch_choice
>
> #define ARRAY_SIZE(a) (sizeof(a) / sizeof(a[0]))
>
>
> -const struct mips_arch_choice mips_arch_choices[] =
> +static const struct mips_arch_choice mips_arch_choices[] =
> {
> { "numeric", 0, 0, 0, 0,
> mips_cp0_names_numeric, NULL, 0, mips_hwr_names_numeric },
> --
> 1.7.0
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-05-09 7:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-06 20:18 [Qemu-devel] [PATCH] mips-dis: Add missing static attributes Stefan Weil
2010-05-07 16:33 ` Blue Swirl
2010-05-07 21:20 ` Stefan Weil
2010-05-09 7:03 ` [Qemu-devel] " Blue Swirl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).