From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=38344 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OBZSq-0008S3-FG for qemu-devel@nongnu.org; Mon, 10 May 2010 16:20:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OBZSn-0000S3-6G for qemu-devel@nongnu.org; Mon, 10 May 2010 16:20:31 -0400 Received: from e34.co.us.ibm.com ([32.97.110.152]:33816) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OBZSm-0000Ru-Ts for qemu-devel@nongnu.org; Mon, 10 May 2010 16:20:29 -0400 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by e34.co.us.ibm.com (8.14.3/8.13.1) with ESMTP id o4AKCw8X030480 for ; Mon, 10 May 2010 14:12:58 -0600 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o4AKKF6V069956 for ; Mon, 10 May 2010 14:20:15 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id o4AKKCKR007743 for ; Mon, 10 May 2010 14:20:14 -0600 From: "Venkateswararao Jujjuri (JV)" Date: Mon, 10 May 2010 13:24:04 -0700 Message-Id: <1273523044-26939-7-git-send-email-jvrao@linux.vnet.ibm.com> In-Reply-To: <1273523044-26939-1-git-send-email-jvrao@linux.vnet.ibm.com> References: <1273523044-26939-1-git-send-email-jvrao@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 6/6] virtio-9p: Implemented Security model for lstat and fstat List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com, "Venkateswararao Jujjuri (JV)" Signed-off-by: Venkateswararao Jujjuri --- hw/virtio-9p-local.c | 67 +++++++++++++++++++++++++++++++++++++++++++++++--- 1 files changed, 63 insertions(+), 4 deletions(-) diff --git a/hw/virtio-9p-local.c b/hw/virtio-9p-local.c index 89b17f0..529de73 100644 --- a/hw/virtio-9p-local.c +++ b/hw/virtio-9p-local.c @@ -27,9 +27,40 @@ static const char *rpath(FsContext *ctx, const char *path) return buffer; } -static int local_lstat(FsContext *ctx, const char *path, struct stat *stbuf) + +static int local_lstat(FsContext *fs_ctx, const char *path, struct stat *stbuf) { - return lstat(rpath(ctx, path), stbuf); + int err; + err = lstat(rpath(fs_ctx, path), stbuf); + if (err) { + return err; + } + if (fs_ctx->fs_sm == sm_mapped) { + /* Actual credentials are part of extended attrs */ + uid_t tmp_uid; + gid_t tmp_gid; + mode_t tmp_mode; + dev_t tmp_dev; + if (getxattr(rpath(fs_ctx, path), "user.virtfs.uid", &tmp_uid, + sizeof(uid_t)) > 0) { + stbuf->st_uid = tmp_uid; + } + if (getxattr(rpath(fs_ctx, path), "user.virtfs.gid", &tmp_gid, + sizeof(gid_t)) > 0) { + stbuf->st_gid = tmp_gid; + } + if (getxattr(rpath(fs_ctx, path), "user.virtfs.mode", &tmp_mode, + sizeof(mode_t)) > 0) { + stbuf->st_mode = tmp_mode; + } + if (S_ISCHR(tmp_mode) || S_ISCHR(tmp_mode)) { + if (getxattr(rpath(fs_ctx, path), "user.virtfs.rdev", &tmp_dev, + sizeof(dev_t)) > 0) { + stbuf->st_rdev = tmp_dev; + } + } + } + return err; } static void local_set_cred(FsCred *credp) @@ -200,9 +231,37 @@ static int local_mkdir(FsContext *fs_ctx, const char *path, FsCred *credp) return err; } -static int local_fstat(FsContext *ctx, int fd, struct stat *stbuf) +static int local_fstat(FsContext *fs_ctx, int fd, struct stat *stbuf) { - return fstat(fd, stbuf); + int err; + err = fstat(fd, stbuf); + if (err) { + return err; + } + if (fs_ctx->fs_sm == sm_mapped) { + /* Actual credentials are part of extended attrs */ + uid_t tmp_uid; + gid_t tmp_gid; + mode_t tmp_mode; + dev_t tmp_dev; + + if (fgetxattr(fd, "user.virtfs.uid", &tmp_uid, sizeof(uid_t)) > 0) { + stbuf->st_uid = tmp_uid; + } + if (fgetxattr(fd, "user.virtfs.gid", &tmp_gid, sizeof(gid_t)) > 0) { + stbuf->st_gid = tmp_gid; + } + if (fgetxattr(fd, "user.virtfs.mode", &tmp_mode, sizeof(mode_t)) > 0) { + stbuf->st_mode = tmp_mode; + } + if (S_ISCHR(tmp_mode) || S_ISCHR(tmp_mode)) { + if (fgetxattr(fd, "user.virtfs.rdev", &tmp_dev, + sizeof(dev_t)) > 0) { + stbuf->st_rdev = tmp_dev; + } + } + } + return err; } static int local_open2(FsContext *fs_ctx, const char *path, int flags, -- 1.6.5.2