From: Alex Williamson <alex.williamson@redhat.com>
To: Sebastian Herbszt <herbszt@gmx.de>
Cc: Kevin O'Connor <kevin@koconnor.net>,
seabios@seabios.org, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [SeaBIOS] [PATCH] smbios: avoid counting io hole as ram
Date: Mon, 10 May 2010 15:25:27 -0600 [thread overview]
Message-ID: <1273526727.2682.24.camel@localhost> (raw)
In-Reply-To: <B0957AC23E6A4E96A07A77939D1A70F6@FSCPC>
On Mon, 2010-05-10 at 23:05 +0200, Sebastian Herbszt wrote:
> Kevin O'Connor wrote:
> > On Fri, May 07, 2010 at 01:38:55PM -0600, Alex Williamson wrote:
> >> Avoid counting the io hole as part of ram, a vm started with 4G
> >> should report 4G in smbios, not 4.5G.
> >>
> >> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> >
> > Looks okay to me. If there are no other comments, I'll commit in the
> > next couple of days.
> >
> > -Kevin
>
> If i don't mistake it seems to address what i have reported back in January
> in the "wrong memsize in smbios_init()" thread [1], correct?
>
> [1] http://www.seabios.org/pipermail/seabios/2010-January/000146.html
Yes, it should fix that. I started out effectively where you did,
changing memsize to RamSize + RamSizeOver4G, but then quickly ran into
the problems Gleb pointed out with some tables wanting address ranges
and others wanting quantity. With this patch tables 16, 17, 19, and 20
should make sense and match the spec. Thanks,
Alex
prev parent reply other threads:[~2010-05-10 21:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 19:38 [Qemu-devel] [PATCH] smbios: avoid counting io hole as ram Alex Williamson
2010-05-07 19:56 ` [Qemu-devel] " Don Dutile
2010-05-10 3:03 ` [Qemu-devel] Re: [SeaBIOS] " Kevin O'Connor
2010-05-10 5:26 ` Gleb Natapov
2010-05-10 21:05 ` Sebastian Herbszt
2010-05-10 21:25 ` Alex Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273526727.2682.24.camel@localhost \
--to=alex.williamson@redhat.com \
--cc=herbszt@gmx.de \
--cc=kevin@koconnor.net \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).