[Qemu-devel] Re: [PATCH 2/2] [block]: Skip refresh_total_sectors() for scsi-generic devices

["Nicholas A. Bellinger" <nab@linux-iscsi.org>]

[-- Attachment #1: Type: text/plain, Size: 916 bytes --]

On Sun, 2010-05-16 at 15:30 +0200, Christoph Hellwig wrote:
> On Sat, May 15, 2010 at 06:30:59AM -0700, Nicholas A. Bellinger wrote:
> > From: Nicholas Bellinger <nab@linux-iscsi.org>
> > 
> > This patch adds a BlockDriverState->sg check in block.c:bdrv_common_open()
> > to skip the new refresh_total_sectors() call once we know we are working with
> > a scsi-generic device.
> > 
> > We go ahead and skip this call for scsi-generic devices because
> > block/raw-posix.c:raw_getlength() -> lseek() will return -ESPIPE.
> 
> How about moving that check into refresh_total_sectors?

Sounds good, attached is updated patch #2:

[PATCH 2/2] [block]: Add SG_IO device check in refresh_total_sectors()

Also, I am using the options in .vimrc to follow QEMU's indent style:

set smartindent
set tabstop=4
set shiftwidth=4
set expandtab

I assume this is what should be used when sending QEMU patches, yes..?

Best,

--nab

[-- Attachment #2: 0002--block-Add-SG_IO-device-check-in-refresh_total_sec.patch --]
[-- Type: application/mbox, Size: 1119 bytes --]