From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=56870 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ODqXb-00073O-6q for qemu-devel@nongnu.org; Sun, 16 May 2010 22:58:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ODqXa-0001rq-36 for qemu-devel@nongnu.org; Sun, 16 May 2010 22:58:51 -0400 Received: from smtp125.sbc.mail.sp1.yahoo.com ([69.147.65.184]:26456) by eggs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1ODqXZ-0001re-Oi for qemu-devel@nongnu.org; Sun, 16 May 2010 22:58:50 -0400 From: "Nicholas A. Bellinger" Date: Mon, 17 May 2010 09:46:04 -0700 Message-Id: <1274114764-27975-1-git-send-email-nab@linux-iscsi.org> Subject: [Qemu-devel] [PATCH 2/2] [block]: Add SG_IO device check in refresh_total_sectors() List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , Christoph Hellwig , Gerd Hoffmann , Hannes Reinecke , kvm-devel , qemu-devel Cc: Nicholas Bellinger From: Nicholas Bellinger This patch adds a special case check for scsi-generic devices in refresh_total_sectors() to skip the subsequent BlockDriver->bdrv_getlength() that will be returning -ESPIPE from block/raw-posic.c:raw_getlength() for BlockDriverState->sg=1 devices. Signed-off-by: Nicholas A. Bellinger --- block.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index f419ee6..7917712 100644 --- a/block.c +++ b/block.c @@ -364,6 +364,10 @@ static int refresh_total_sectors(BlockDriverState *bs, int64_t hint) { BlockDriver *drv = bs->drv; + /* Do not attempt drv->bdrv_getlength() on scsi-generic devices */ + if (bs->sg) + return 0; + /* query actual device if possible, otherwise just trust the hint */ if (drv->bdrv_getlength) { int64_t length = drv->bdrv_getlength(bs); -- 1.5.6.5