From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 5/8] block: Make find_image_format() return 'raw' BlockDriver for SG_IO devices
Date: Thu, 20 May 2010 15:10:40 +0200 [thread overview]
Message-ID: <1274361043-25862-6-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1274361043-25862-1-git-send-email-kwolf@redhat.com>
From: Nicholas Bellinger <nab@linux-iscsi.org>
This patch adds a special BlockDriverState->sg check in block.c:find_image_format()
after bdrv_file_open() -> block/raw-posix.c:hdev_open() has been called to determine
if we are dealing with a Linux host scsi-generic device.
The patch then returns the BlockDriver * from bdrv_find_format("raw"), skipping the
subsequent bdrv_read() and rest of find_image_format().
Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/block.c b/block.c
index 89eece7..6a95768 100644
--- a/block.c
+++ b/block.c
@@ -329,6 +329,11 @@ static BlockDriver *find_image_format(const char *filename)
ret = bdrv_file_open(&bs, filename, 0);
if (ret < 0)
return NULL;
+
+ /* Return the raw BlockDriver * to scsi-generic devices */
+ if (bs->sg)
+ return bdrv_find_format("raw");
+
ret = bdrv_pread(bs, 0, buf, sizeof(buf));
bdrv_delete(bs);
if (ret < 0) {
--
1.6.6.1
next prev parent reply other threads:[~2010-05-20 13:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-20 13:10 [Qemu-devel] [PULL 0/8] Block patches Kevin Wolf
2010-05-20 13:10 ` [Qemu-devel] [PATCH 1/8] block: fix aio_flush segfaults for read-only protocols (e.g. curl) Kevin Wolf
2010-05-20 13:10 ` [Qemu-devel] [PATCH 2/8] virtio-blk: Avoid zeroing every request structure Kevin Wolf
2010-05-20 13:10 ` [Qemu-devel] [PATCH 3/8] virtio-blk: fix barrier support Kevin Wolf
2010-05-20 13:10 ` [Qemu-devel] [PATCH 4/8] block: fix sector comparism in multiwrite_req_compare Kevin Wolf
2010-05-20 13:10 ` Kevin Wolf [this message]
2010-05-20 13:10 ` [Qemu-devel] [PATCH 6/8] block: Add SG_IO device check in refresh_total_sectors() Kevin Wolf
2010-05-20 13:10 ` [Qemu-devel] [PATCH 7/8] vvfat: Fix compilation with DEBUG defined Kevin Wolf
2010-05-20 13:10 ` [Qemu-devel] [PATCH 8/8] vvfat: More build fixes with DEBUG Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274361043-25862-6-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).