From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 6/8] block: Add SG_IO device check in refresh_total_sectors()
Date: Thu, 20 May 2010 15:10:41 +0200 [thread overview]
Message-ID: <1274361043-25862-7-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1274361043-25862-1-git-send-email-kwolf@redhat.com>
From: Nicholas Bellinger <nab@linux-iscsi.org>
This patch adds a special case check for scsi-generic devices in
refresh_total_sectors() to skip the subsequent BlockDriver->bdrv_getlength()
that will be returning -ESPIPE from block/raw-posic.c:raw_getlength() for
BlockDriverState->sg=1 devices.
Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/block.c b/block.c
index 6a95768..0b0966c 100644
--- a/block.c
+++ b/block.c
@@ -361,6 +361,10 @@ static int refresh_total_sectors(BlockDriverState *bs, int64_t hint)
{
BlockDriver *drv = bs->drv;
+ /* Do not attempt drv->bdrv_getlength() on scsi-generic devices */
+ if (bs->sg)
+ return 0;
+
/* query actual device if possible, otherwise just trust the hint */
if (drv->bdrv_getlength) {
int64_t length = drv->bdrv_getlength(bs);
--
1.6.6.1
next prev parent reply other threads:[~2010-05-20 13:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-20 13:10 [Qemu-devel] [PULL 0/8] Block patches Kevin Wolf
2010-05-20 13:10 ` [Qemu-devel] [PATCH 1/8] block: fix aio_flush segfaults for read-only protocols (e.g. curl) Kevin Wolf
2010-05-20 13:10 ` [Qemu-devel] [PATCH 2/8] virtio-blk: Avoid zeroing every request structure Kevin Wolf
2010-05-20 13:10 ` [Qemu-devel] [PATCH 3/8] virtio-blk: fix barrier support Kevin Wolf
2010-05-20 13:10 ` [Qemu-devel] [PATCH 4/8] block: fix sector comparism in multiwrite_req_compare Kevin Wolf
2010-05-20 13:10 ` [Qemu-devel] [PATCH 5/8] block: Make find_image_format() return 'raw' BlockDriver for SG_IO devices Kevin Wolf
2010-05-20 13:10 ` Kevin Wolf [this message]
2010-05-20 13:10 ` [Qemu-devel] [PATCH 7/8] vvfat: Fix compilation with DEBUG defined Kevin Wolf
2010-05-20 13:10 ` [Qemu-devel] [PATCH 8/8] vvfat: More build fixes with DEBUG Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274361043-25862-7-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).