qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: corentin.chary@gmail.com, paul@codesourcery.com,
	aurelien@aurel32.net, stefanha@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH 1/2] Use calloc in qemu_mallocz.
Date: Fri, 21 May 2010 10:37:51 -0700	[thread overview]
Message-ID: <1274463472-17353-2-git-send-email-rth@twiddle.net> (raw)
In-Reply-To: <AANLkTim4-lT__IuYnRWkcniN8keX_y9COZCFIPf1Grcy@mail.gmail.com>

Avoids the memset if the allocator has gotten new zeroed
storage from the operating system.

Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 qemu-malloc.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/qemu-malloc.c b/qemu-malloc.c
index 6cdc5de..1b33e04 100644
--- a/qemu-malloc.c
+++ b/qemu-malloc.c
@@ -69,10 +69,10 @@ void *qemu_realloc(void *ptr, size_t size)
 
 void *qemu_mallocz(size_t size)
 {
-    void *ptr;
-    ptr = qemu_malloc(size);
-    memset(ptr, 0, size);
-    return ptr;
+    if (!size && !allow_zero_malloc()) {
+        abort();
+    }
+    return oom_check(calloc(1, size ? size : 1));
 }
 
 char *qemu_strdup(const char *str)
-- 
1.7.0.1

  parent reply	other threads:[~2010-05-21 17:38 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-14 21:52 [Qemu-devel] [PATCH] virtio-blk: Avoid zeroing every request structure Stefan Hajnoczi
2010-05-16 13:25 ` Christoph Hellwig
2010-05-16 15:01   ` Stefan Hajnoczi
2010-05-18  9:36 ` Kevin Wolf
2010-05-18 15:46 ` Jes Sorensen
2010-05-18 16:26   ` Alexander Graf
2010-05-18 16:29     ` Anthony Liguori
2010-05-18 16:31       ` Alexander Graf
2010-05-29 13:07         ` Jamie Lokier
2010-05-18 16:37 ` Corentin Chary
2010-05-18 19:02   ` Stefan Hajnoczi
2010-05-18 19:55     ` Corentin Chary
2010-05-18 20:43       ` Stefan Hajnoczi
2010-05-21 11:17         ` Stefan Hajnoczi
2010-05-21 17:37           ` [Qemu-devel] [PATCH 0/2] Tidy qemu_malloc Richard Henderson
2010-05-28 22:08             ` Aurelien Jarno
2010-05-21 17:37           ` Richard Henderson [this message]
2010-05-21 17:37           ` [Qemu-devel] [PATCH 2/2] linux-user: Use qemu-malloc.c Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1274463472-17353-2-git-send-email-rth@twiddle.net \
    --to=rth@twiddle.net \
    --cc=aurelien@aurel32.net \
    --cc=corentin.chary@gmail.com \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).