qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Corentin Chary <corentincj@iksaif.net>
To: qemu-devel@nongnu.org
Cc: Corentin Chary <corentincj@iksaif.net>,
	Anthony Liguori <aliguori@linux.vnet.ibm.com>,
	Alexander Graf <agraf@suse.de>, Adam Litke <agl@us.ibm.com>
Subject: [Qemu-devel] [PATCH 1/3] vnc: tight: don't forget last pixel in tight_encode_indexed_rect
Date: Thu, 27 May 2010 08:21:52 +0200	[thread overview]
Message-ID: <1274941314-7493-1-git-send-email-corentincj@iksaif.net> (raw)
In-Reply-To: <1274253852-16068-1-git-send-email-corentincj@iksaif.net>

A simple patch would have been to just remove count -= 1, but this
one also replace the while (count--) with a for(i = 0; i < count; i++)
which I believe is more easy to understand.

Signed-off-by: Corentin Chary <corentincj@iksaif.net>
---
 vnc-encoding-tight.c |    9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/vnc-encoding-tight.c b/vnc-encoding-tight.c
index 50be44e..c8effe6 100644
--- a/vnc-encoding-tight.c
+++ b/vnc-encoding-tight.c
@@ -249,17 +249,16 @@ static void print_palette(const char *key, QObject *obj, void *opaque)
         uint##bpp##_t *src;                                             \
         uint##bpp##_t rgb;                                              \
         uint8_t key[6];                                                 \
-        int rep = 0;                                                    \
+        int i = 0, rep = 0;                                             \
         uint8_t idx;                                                    \
                                                                         \
         src = (uint##bpp##_t *) buf;                                    \
                                                                         \
-        count -= 1;                                                     \
-        while (count--) {                                               \
+        for (i = 0; i < count; i++) {                                   \
             rgb = *src++;                                               \
             rep = 0;                                                    \
-            while (count && *src == rgb) {                              \
-                rep++, src++, count--;                                  \
+            while (i < count && *src == rgb) {                          \
+                rep++, src++, i++;                                      \
             }                                                           \
             tight_palette_rgb2buf(rgb, bpp, key);                       \
             if (!qdict_haskey(palette, (char *)key)) {                  \
-- 
1.7.1

  parent reply	other threads:[~2010-05-27  6:22 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-19  7:24 [Qemu-devel] [PATCH v3 00/12] *** SUBJECT HERE *** Corentin Chary
2010-05-19  7:24 ` [Qemu-devel] [PATCH v3 01/12] Revert "vnc: set the right prefered encoding" Corentin Chary
2010-06-01 18:27   ` Anthony Liguori
2010-05-19  7:24 ` [Qemu-devel] [PATCH v3 02/12] vnc: explain why set_encodings loop is reversed Corentin Chary
2010-05-19  7:24 ` [Qemu-devel] [PATCH v3 03/12] vnc: really call zlib if we want zlib Corentin Chary
2010-05-19  7:24 ` [Qemu-devel] [PATCH v3 04/12] vnc: only use a single zlib stream Corentin Chary
2010-05-19  7:24 ` [Qemu-devel] [PATCH v3 05/12] vnc: adjust compression zstream level Corentin Chary
2010-05-19  7:24 ` [Qemu-devel] [PATCH v3 06/12] vnc: don't clear zlib stream on set_encoding Corentin Chary
2010-05-19  7:24 ` [Qemu-devel] [PATCH v3 07/12] vnc: add buffer_free() Corentin Chary
2010-05-19  7:24 ` [Qemu-devel] [PATCH v3 08/12] vnc: remove a memory leak in zlib Corentin Chary
2010-05-19  7:24 ` [Qemu-devel] [PATCH v3 09/12] vnc: return the number of rectangles Corentin Chary
2010-05-19  7:24 ` [Qemu-devel] [PATCH v3 10/12] vnc: add basic tight support Corentin Chary
2010-05-19  7:24 ` [Qemu-devel] [PATCH v3 11/12] vnc: add support for tight fill encoding Corentin Chary
2010-05-19  7:24 ` [Qemu-devel] [PATCH v3 12/12] vnc: tight: add palette encoding Corentin Chary
2010-05-19  7:31 ` [Qemu-devel] [PATCH v3 00/12] *** SUBJECT HERE *** Corentin Chary
2010-05-27  6:21 ` Corentin Chary [this message]
2010-05-27 14:28   ` [Qemu-devel] [PATCH 1/3] vnc: tight: don't forget last pixel in tight_encode_indexed_rect Richard Henderson
2010-06-01 21:01     ` Corentin Chary
2010-05-27  6:21 ` [Qemu-devel] [PATCH 2/3] vnc: tight: don't forget the third color Corentin Chary
2010-05-27  6:21 ` [Qemu-devel] [PATCH 3/3] vnc: add missing target for vnc-encodings-*.o Corentin Chary
  -- strict thread matches above, loose matches on Subject: below --
2010-06-01 21:05 [Qemu-devel] [PATCH 0/3] Small tight fixes Corentin Chary
2010-06-01 21:05 ` [Qemu-devel] [PATCH 1/3] vnc: tight: don't forget last pixel in tight_encode_indexed_rect Corentin Chary
2010-06-01 21:17   ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1274941314-7493-1-git-send-email-corentincj@iksaif.net \
    --to=corentincj@iksaif.net \
    --cc=agl@us.ibm.com \
    --cc=agraf@suse.de \
    --cc=aliguori@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).