From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [STABLE PATCH 2/6] qcow2: Clear L2 table cache after write error
Date: Fri, 28 May 2010 20:01:28 +0200 [thread overview]
Message-ID: <1275069692-5756-3-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1275069692-5756-1-git-send-email-kwolf@redhat.com>
If the L2 table was already updated in cache, but writing it to disk has
failed, we must not continue using the changed version in the cache to stay
consistent with what's on the disk.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
(cherry picked from commit 1b7c801b40ce90795397bb566d019c9b76ef9c13)
Conflicts:
block/qcow2-cluster.c
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block/qcow2-cluster.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index c7057b1..0dc4f1d 100644
--- a/block/qcow2-cluster.c
+++ b/block/qcow2-cluster.c
@@ -672,8 +672,9 @@ int qcow2_alloc_cluster_link_l2(BlockDriverState *bs, QCowL2Meta *m)
(i << s->cluster_bits)) | QCOW_OFLAG_COPIED);
}
- if (write_l2_entries(s, l2_table, l2_offset, l2_index, m->nb_clusters) < 0) {
- ret = -1;
+ ret = write_l2_entries(s, l2_table, l2_offset, l2_index, m->nb_clusters);
+ if (ret < 0) {
+ qcow2_l2_cache_reset(bs);
goto err;
}
--
1.6.6.1
next prev parent reply other threads:[~2010-05-28 18:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-28 18:01 [Qemu-devel] [STABLE PULL 0/6] Block patches for 0.12.x Kevin Wolf
2010-05-28 18:01 ` [Qemu-devel] [STABLE PATCH 1/6] ide: Fix ide_dma_cancel Kevin Wolf
2010-05-28 18:01 ` Kevin Wolf [this message]
2010-05-28 18:01 ` [Qemu-devel] [STABLE PATCH 3/6] qcow2: Fix error handling in l2_allocate Kevin Wolf
2010-05-28 18:01 ` [Qemu-devel] [STABLE PATCH 4/6] block: Fix multiwrite with overlapping requests Kevin Wolf
2010-05-28 18:01 ` [Qemu-devel] [STABLE PATCH 5/6] qcow2: Fix corruption after refblock allocation Kevin Wolf
2010-05-28 18:01 ` [Qemu-devel] [STABLE PATCH 6/6] qcow2: Fix corruption after error in update_refcount Kevin Wolf
2010-06-09 16:41 ` [Qemu-devel] [STABLE PULL 0/6] Block patches for 0.12.x Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275069692-5756-3-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).