qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [STABLE PATCH 4/6] block: Fix multiwrite with overlapping requests
Date: Fri, 28 May 2010 20:01:30 +0200	[thread overview]
Message-ID: <1275069692-5756-5-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1275069692-5756-1-git-send-email-kwolf@redhat.com>

With overlapping requests, the total number of sectors is smaller than the sum
of the nb_sectors of both requests.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
(cherry picked from commit cbf1dff2f1033cadcb15c0ffc9c0a3d039d8ed42)
---
 block.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/block.c b/block.c
index 955eeaa..298414c 100644
--- a/block.c
+++ b/block.c
@@ -1711,7 +1711,7 @@ static int multiwrite_merge(BlockDriverState *bs, BlockRequest *reqs,
             // Add the second request
             qemu_iovec_concat(qiov, reqs[i].qiov, reqs[i].qiov->size);
 
-            reqs[outidx].nb_sectors += reqs[i].nb_sectors;
+            reqs[outidx].nb_sectors = qiov->size >> 9;
             reqs[outidx].qiov = qiov;
 
             mcb->callbacks[i].free_qiov = reqs[outidx].qiov;
-- 
1.6.6.1

  parent reply	other threads:[~2010-05-28 18:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-28 18:01 [Qemu-devel] [STABLE PULL 0/6] Block patches for 0.12.x Kevin Wolf
2010-05-28 18:01 ` [Qemu-devel] [STABLE PATCH 1/6] ide: Fix ide_dma_cancel Kevin Wolf
2010-05-28 18:01 ` [Qemu-devel] [STABLE PATCH 2/6] qcow2: Clear L2 table cache after write error Kevin Wolf
2010-05-28 18:01 ` [Qemu-devel] [STABLE PATCH 3/6] qcow2: Fix error handling in l2_allocate Kevin Wolf
2010-05-28 18:01 ` Kevin Wolf [this message]
2010-05-28 18:01 ` [Qemu-devel] [STABLE PATCH 5/6] qcow2: Fix corruption after refblock allocation Kevin Wolf
2010-05-28 18:01 ` [Qemu-devel] [STABLE PATCH 6/6] qcow2: Fix corruption after error in update_refcount Kevin Wolf
2010-06-09 16:41 ` [Qemu-devel] [STABLE PULL 0/6] Block patches for 0.12.x Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1275069692-5756-5-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).