* [Qemu-devel] [PATCH] ahci: drop board_ahci constants
@ 2010-05-31 20:12 Sebastian Herbszt
2010-05-31 20:13 ` [Qemu-devel] Re: [Qemu-ahci-devel] " Alexander Graf
0 siblings, 1 reply; 3+ messages in thread
From: Sebastian Herbszt @ 2010-05-31 20:12 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-ahci-devel, Sebastian Herbszt
Drop not used board_ahci constants.
Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
diff --git a/hw/ahci.c b/hw/ahci.c
index 3476cea..4090def 100644
--- a/hw/ahci.c
+++ b/hw/ahci.c
@@ -65,12 +65,6 @@ do { fprintf(stderr,"ahci: " fmt , ## __VA_ARGS__); } while (0)
#define RX_FIS_SDB 0x58 /* offset of SDB FIS data */
#define RX_FIS_UNK 0x60 /* offset of Unknown FIS data */
-#define board_ahci 0
-#define board_ahci_pi 1
-#define board_ahci_vt8251 2
-#define board_ahci_ign_iferr 3
-#define board_ahci_sb600 4
-
/* global controller registers */
#define HOST_CAP 0x00 /* host capabilities */
#define HOST_CTL 0x04 /* global host control */
^ permalink raw reply related [flat|nested] 3+ messages in thread* [Qemu-devel] Re: [Qemu-ahci-devel] [PATCH] ahci: drop board_ahci constants
2010-05-31 20:12 [Qemu-devel] [PATCH] ahci: drop board_ahci constants Sebastian Herbszt
@ 2010-05-31 20:13 ` Alexander Graf
2010-05-31 20:21 ` Sebastian Herbszt
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Graf @ 2010-05-31 20:13 UTC (permalink / raw)
To: Sebastian Herbszt; +Cc: qemu-ahci-devel, qemu-devel
On 31.05.2010, at 22:12, Sebastian Herbszt wrote:
> Drop not used board_ahci constants.
>
> Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
>
> diff --git a/hw/ahci.c b/hw/ahci.c
> index 3476cea..4090def 100644
> --- a/hw/ahci.c
> +++ b/hw/ahci.c
> @@ -65,12 +65,6 @@ do { fprintf(stderr,"ahci: " fmt , ## __VA_ARGS__); } while (0)
> #define RX_FIS_SDB 0x58 /* offset of SDB FIS data */
> #define RX_FIS_UNK 0x60 /* offset of Unknown FIS data */
>
> -#define board_ahci 0
> -#define board_ahci_pi 1
> -#define board_ahci_vt8251 2
> -#define board_ahci_ign_iferr 3
> -#define board_ahci_sb600 4
> -
They weren't used before? Why are they there at all then?
Alex
^ permalink raw reply [flat|nested] 3+ messages in thread* [Qemu-devel] Re: [Qemu-ahci-devel] [PATCH] ahci: drop board_ahci constants
2010-05-31 20:13 ` [Qemu-devel] Re: [Qemu-ahci-devel] " Alexander Graf
@ 2010-05-31 20:21 ` Sebastian Herbszt
0 siblings, 0 replies; 3+ messages in thread
From: Sebastian Herbszt @ 2010-05-31 20:21 UTC (permalink / raw)
To: Alexander Graf; +Cc: qemu-ahci-devel, qemu-devel
Alexander Graf wrote:
> On 31.05.2010, at 22:12, Sebastian Herbszt wrote:
>> Drop not used board_ahci constants.
>>
>> Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
>>
>> diff --git a/hw/ahci.c b/hw/ahci.c
>> index 3476cea..4090def 100644
>> --- a/hw/ahci.c
>> +++ b/hw/ahci.c
>> @@ -65,12 +65,6 @@ do { fprintf(stderr,"ahci: " fmt , ## __VA_ARGS__); } while (0)
>> #define RX_FIS_SDB 0x58 /* offset of SDB FIS data */
>> #define RX_FIS_UNK 0x60 /* offset of Unknown FIS data */
>>
>> -#define board_ahci 0
>> -#define board_ahci_pi 1
>> -#define board_ahci_vt8251 2
>> -#define board_ahci_ign_iferr 3
>> -#define board_ahci_sb600 4
>> -
>
> They weren't used before? Why are they there at all then?
>
> Alex
Copy and paste from the linux kernel (ahci.c/h)?
Sebastian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-05-31 20:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-31 20:12 [Qemu-devel] [PATCH] ahci: drop board_ahci constants Sebastian Herbszt
2010-05-31 20:13 ` [Qemu-devel] Re: [Qemu-ahci-devel] " Alexander Graf
2010-05-31 20:21 ` Sebastian Herbszt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).