* [Qemu-devel] [PATCH] ahci: drop ATAPI_CMD constants
@ 2010-05-31 20:56 Sebastian Herbszt
2010-05-31 21:26 ` [Qemu-devel] Re: [Qemu-ahci-devel] " Alexander Graf
0 siblings, 1 reply; 2+ messages in thread
From: Sebastian Herbszt @ 2010-05-31 20:56 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-ahci-devel, Sebastian Herbszt
Drop not used ATAPI_CMD constants.
Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
diff --git a/hw/ahci.c b/hw/ahci.c
index 9987459..a024706 100644
--- a/hw/ahci.c
+++ b/hw/ahci.c
@@ -179,21 +179,6 @@ do { fprintf(stderr,"ahci: " fmt , ## __VA_ARGS__); } while (0)
#define ATA_CMD_WRITE_EXT 0x34 /* Write Sectores (with retries) with 48bit addressing */
#define ATA_CMD_VRFY_EXT 0x42 /* Read Verify (with retries) with 48bit addressing */
-/*
- * ATAPI Commands
- */
-#define ATAPI_CMD_IDENT 0xA1 /* Identify AT Atachment Packed Interface Device */
-#define ATAPI_CMD_PACKET 0xA0 /* Packed Command */
-
-
-#define ATAPI_CMD_INQUIRY 0x12
-#define ATAPI_CMD_REQ_SENSE 0x03
-#define ATAPI_CMD_READ_CAP 0x25
-#define ATAPI_CMD_START_STOP 0x1B
-#define ATAPI_CMD_READ_12 0xA8
-
-
-
typedef struct ahci_control_regs {
uint32_t cap;
uint32_t ghc;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Qemu-devel] Re: [Qemu-ahci-devel] [PATCH] ahci: drop ATAPI_CMD constants
2010-05-31 20:56 [Qemu-devel] [PATCH] ahci: drop ATAPI_CMD constants Sebastian Herbszt
@ 2010-05-31 21:26 ` Alexander Graf
0 siblings, 0 replies; 2+ messages in thread
From: Alexander Graf @ 2010-05-31 21:26 UTC (permalink / raw)
To: Sebastian Herbszt; +Cc: qemu-ahci-devel, qemu-devel
On 31.05.2010, at 22:56, Sebastian Herbszt wrote:
> Drop not used ATAPI_CMD constants.
I'd postpone that. We should get rid of _all_ ATA and ATAPI commands in ahci.c, but that'll be part of a bigger cleanup. IMHO we should reuse the IDE core for those.
Alex
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-05-31 21:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-31 20:56 [Qemu-devel] [PATCH] ahci: drop ATAPI_CMD constants Sebastian Herbszt
2010-05-31 21:26 ` [Qemu-devel] Re: [Qemu-ahci-devel] " Alexander Graf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).