qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "M. Mohan Kumar" <mohan@in.ibm.com>
To: qemu-devel@nongnu.org, v9fs-developer@lists.sourceforge.net
Subject: [Qemu-devel] 9p: [RFC] [PATCH 02/02] Make use of iounit for read/write
Date: Tue,  1 Jun 2010 19:47:49 +0530	[thread overview]
Message-ID: <1275401869-27560-1-git-send-email-mohan@in.ibm.com> (raw)
In-Reply-To: <1275401834-27520-1-git-send-email-mohan@in.ibm.com>

Change the v9fs_file_readn function to limit the maximum transfer size
based on the iounit instead of msize.

Also remove the redundant check for limiting the transfer size in
v9fs_file_write. This check is done by p9_client_write.

Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
---
 fs/9p/vfs_file.c |   10 ++--------
 1 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c
index 25b300e..b8c0891 100644
--- a/fs/9p/vfs_file.c
+++ b/fs/9p/vfs_file.c
@@ -160,7 +160,7 @@ v9fs_file_readn(struct file *filp, char *data, char __user *udata, u32 count,
 		offset += n;
 		count -= n;
 		total += n;
-	} while (count > 0 && n == (fid->clnt->msize - P9_IOHDRSZ));
+	} while (count > 0 && n == fid->iounit);
 
 	if (n < 0)
 		total = n;
@@ -187,11 +187,7 @@ v9fs_file_read(struct file *filp, char __user *udata, size_t count,
 	P9_DPRINTK(P9_DEBUG_VFS, "count %zu offset %lld\n", count, *offset);
 	fid = filp->private_data;
 
-	if (count > (fid->clnt->msize - P9_IOHDRSZ))
-		ret = v9fs_file_readn(filp, NULL, udata, count, *offset);
-	else
-		ret = p9_client_read(fid, NULL, udata, *offset, count);
-
+	ret = v9fs_file_readn(filp, NULL, udata, count, *offset);
 	if (ret > 0)
 		*offset += ret;
 
@@ -225,8 +221,6 @@ v9fs_file_write(struct file *filp, const char __user * data,
 	clnt = fid->clnt;
 
 	rsize = fid->iounit;
-	if (!rsize || rsize > clnt->msize-P9_IOHDRSZ)
-		rsize = clnt->msize - P9_IOHDRSZ;
 
 	do {
 		if (count < rsize)
-- 
1.6.6.1

  reply	other threads:[~2010-06-01 14:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-01 14:17 [Qemu-devel] qemu:virtio-9p: [RFC] [PATCH 01/02] Send iounit to client for read/write operations M. Mohan Kumar
2010-06-01 14:17 ` M. Mohan Kumar [this message]
2010-06-04  7:07   ` [Qemu-devel] 9p: [RFC] [PATCH 02/02] Make use of iounit for read/write Sripathi Kodi
2010-06-02 11:47 ` [Qemu-devel] Re: [V9fs-developer] qemu:virtio-9p: [RFC] [PATCH 01/02] Send iounit to client for read/write operations Aneesh Kumar K. V
2010-06-04  6:51 ` [Qemu-devel] " Sripathi Kodi
2010-06-06 19:48   ` Venkateswararao Jujjuri (JV)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1275401869-27560-1-git-send-email-mohan@in.ibm.com \
    --to=mohan@in.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=v9fs-developer@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).