From: Jes.Sorensen@redhat.com
To: anthony@codemonkey.ws
Cc: Jes Sorensen <Jes.Sorensen@redhat.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 14/16] Make os_change_process_uid and os_change_root os-posix.c local
Date: Thu, 3 Jun 2010 18:48:10 +0200 [thread overview]
Message-ID: <1275583692-11678-15-git-send-email-Jes.Sorensen@redhat.com> (raw)
In-Reply-To: <1275583692-11678-1-git-send-email-Jes.Sorensen@redhat.com>
From: Jes Sorensen <Jes.Sorensen@redhat.com>
os_change_process_uid() and os_change_root() are now only called
from os-posix.c, so no need to keep win32 stubs for them.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
---
os-posix.c | 8 ++++----
qemu-os-posix.h | 2 --
qemu-os-win32.h | 2 --
3 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/os-posix.c b/os-posix.c
index 8a9d102..7ac6f07 100644
--- a/os-posix.c
+++ b/os-posix.c
@@ -184,7 +184,7 @@ int os_parse_cmd_args(const QEMUOption *popt, const char *optarg)
return ret;
}
-void os_change_process_uid(void)
+static void change_process_uid(void)
{
if (user_pwd) {
if (setgid(user_pwd->pw_gid) < 0) {
@@ -202,7 +202,7 @@ void os_change_process_uid(void)
}
}
-void os_change_root(void)
+static void change_root(void)
{
if (chroot_dir) {
if (chroot(chroot_dir) < 0) {
@@ -291,8 +291,8 @@ void os_setup_post(void)
exit(1);
}
- os_change_root();
- os_change_process_uid();
+ change_root();
+ change_process_uid();
if (daemonize) {
dup2(fd, 0);
diff --git a/qemu-os-posix.h b/qemu-os-posix.h
index 9b07660..8be583d 100644
--- a/qemu-os-posix.h
+++ b/qemu-os-posix.h
@@ -31,8 +31,6 @@ static inline void os_host_main_loop_wait(int *timeout)
}
void os_setup_signal_handling(void);
-void os_change_process_uid(void);
-void os_change_root(void);
void os_daemonize(void);
void os_setup_post(void);
diff --git a/qemu-os-win32.h b/qemu-os-win32.h
index ccb9691..facd3d6 100644
--- a/qemu-os-win32.h
+++ b/qemu-os-win32.h
@@ -43,8 +43,6 @@ void qemu_del_wait_object(HANDLE handle, WaitObjectFunc *func, void *opaque);
void os_host_main_loop_wait(int *timeout);
static inline void os_setup_signal_handling(void) {};
-static inline void os_change_process_uid(void) {};
-static inline void os_change_root(void) {};
static inline void os_daemonize(void) {};
static inline void os_setup_post(void) {};
--
1.6.5.2
next prev parent reply other threads:[~2010-06-03 16:48 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-03 16:47 [Qemu-devel] [PATCH 00/16] clean up vl.c code Jes.Sorensen
2010-06-03 16:47 ` [Qemu-devel] [PATCH 01/16] vl.c: Remove double include of netinet/in.h for Solaris Jes.Sorensen
2010-06-03 16:47 ` [Qemu-devel] [PATCH 02/16] Create qemu-os-win32.h and move WIN32 specific declarations there Jes.Sorensen
2010-06-03 16:47 ` [Qemu-devel] [PATCH 03/16] Introduce os-win32.c and move polling functions from vl.c Jes.Sorensen
2010-06-03 16:48 ` [Qemu-devel] [PATCH 04/16] vl.c: Move host_main_loop_wait() to OS specific files Jes.Sorensen
2010-06-03 16:48 ` [Qemu-devel] [PATCH 05/16] Introduce os-posix.c and create os_setup_signal_handling() Jes.Sorensen
2010-06-03 20:50 ` Richard Henderson
2010-06-04 6:45 ` Jes Sorensen
2010-06-03 16:48 ` [Qemu-devel] [PATCH 06/16] Move win32 early signal handling setup to os_setup_signal_handling() Jes.Sorensen
2010-06-03 16:48 ` [Qemu-devel] [PATCH 07/16] Rename os_setup_signal_handling() to os_setup_early_signal_handling() Jes.Sorensen
2010-06-03 16:48 ` [Qemu-devel] [PATCH 08/16] Move main signal handler setup to os specificfiles Jes.Sorensen
2010-06-03 20:52 ` Richard Henderson
2010-06-04 6:45 ` Jes Sorensen
2010-06-04 7:45 ` Markus Armbruster
2010-06-03 16:48 ` [Qemu-devel] [PATCH 09/16] Move find_datadir to OS specific files Jes.Sorensen
2010-06-03 16:48 ` [Qemu-devel] [PATCH 10/16] Introduce OS specific cmdline argument handling and move SMB arg to os-posix.c Jes.Sorensen
2010-06-03 20:58 ` Richard Henderson
2010-06-04 6:47 ` Jes Sorensen
2010-06-04 14:49 ` Richard Henderson
2010-06-04 14:51 ` Jes Sorensen
2010-06-04 8:15 ` Markus Armbruster
2010-06-04 8:21 ` Jes Sorensen
2010-06-04 10:39 ` [Qemu-devel] " Paolo Bonzini
2010-06-04 11:59 ` Jes Sorensen
2010-06-04 12:04 ` [Qemu-devel] " Markus Armbruster
2010-06-04 12:11 ` Jes Sorensen
2010-06-03 16:48 ` [Qemu-devel] [PATCH 11/16] Move runas handling from vl.c to OS specific files Jes.Sorensen
2010-06-03 21:00 ` Richard Henderson
2010-06-03 16:48 ` [Qemu-devel] [PATCH 12/16] Move chroot handling " Jes.Sorensen
2010-06-03 21:02 ` Richard Henderson
2010-06-04 6:48 ` Jes Sorensen
2010-06-03 16:48 ` [Qemu-devel] [PATCH 13/16] Move daemonize " Jes.Sorensen
2010-06-03 16:48 ` Jes.Sorensen [this message]
2010-06-03 16:48 ` [Qemu-devel] [PATCH 15/16] Move line-buffering setup " Jes.Sorensen
2010-06-03 16:48 ` [Qemu-devel] [PATCH 16/16] Move set_proc_name() " Jes.Sorensen
2010-06-04 8:21 ` [Qemu-devel] [PATCH 00/16] clean up vl.c code Markus Armbruster
2010-06-04 8:23 ` Jes Sorensen
2010-06-04 11:54 ` Markus Armbruster
2010-06-04 11:57 ` Jes Sorensen
2010-06-09 7:07 ` Markus Armbruster
2010-06-09 8:14 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275583692-11678-15-git-send-email-Jes.Sorensen@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).