From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=59664 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OKDb2-0002jg-J7 for qemu-devel@nongnu.org; Thu, 03 Jun 2010 12:48:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OKDb1-00069p-76 for qemu-devel@nongnu.org; Thu, 03 Jun 2010 12:48:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20941) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OKDb0-00069k-VI for qemu-devel@nongnu.org; Thu, 03 Jun 2010 12:48:43 -0400 From: Jes.Sorensen@redhat.com Date: Thu, 3 Jun 2010 18:48:10 +0200 Message-Id: <1275583692-11678-15-git-send-email-Jes.Sorensen@redhat.com> In-Reply-To: <1275583692-11678-1-git-send-email-Jes.Sorensen@redhat.com> References: <1275583692-11678-1-git-send-email-Jes.Sorensen@redhat.com> Subject: [Qemu-devel] [PATCH 14/16] Make os_change_process_uid and os_change_root os-posix.c local List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: Jes Sorensen , qemu-devel@nongnu.org From: Jes Sorensen os_change_process_uid() and os_change_root() are now only called from os-posix.c, so no need to keep win32 stubs for them. Signed-off-by: Jes Sorensen --- os-posix.c | 8 ++++---- qemu-os-posix.h | 2 -- qemu-os-win32.h | 2 -- 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/os-posix.c b/os-posix.c index 8a9d102..7ac6f07 100644 --- a/os-posix.c +++ b/os-posix.c @@ -184,7 +184,7 @@ int os_parse_cmd_args(const QEMUOption *popt, const char *optarg) return ret; } -void os_change_process_uid(void) +static void change_process_uid(void) { if (user_pwd) { if (setgid(user_pwd->pw_gid) < 0) { @@ -202,7 +202,7 @@ void os_change_process_uid(void) } } -void os_change_root(void) +static void change_root(void) { if (chroot_dir) { if (chroot(chroot_dir) < 0) { @@ -291,8 +291,8 @@ void os_setup_post(void) exit(1); } - os_change_root(); - os_change_process_uid(); + change_root(); + change_process_uid(); if (daemonize) { dup2(fd, 0); diff --git a/qemu-os-posix.h b/qemu-os-posix.h index 9b07660..8be583d 100644 --- a/qemu-os-posix.h +++ b/qemu-os-posix.h @@ -31,8 +31,6 @@ static inline void os_host_main_loop_wait(int *timeout) } void os_setup_signal_handling(void); -void os_change_process_uid(void); -void os_change_root(void); void os_daemonize(void); void os_setup_post(void); diff --git a/qemu-os-win32.h b/qemu-os-win32.h index ccb9691..facd3d6 100644 --- a/qemu-os-win32.h +++ b/qemu-os-win32.h @@ -43,8 +43,6 @@ void qemu_del_wait_object(HANDLE handle, WaitObjectFunc *func, void *opaque); void os_host_main_loop_wait(int *timeout); static inline void os_setup_signal_handling(void) {}; -static inline void os_change_process_uid(void) {}; -static inline void os_change_root(void) {}; static inline void os_daemonize(void) {}; static inline void os_setup_post(void) {}; -- 1.6.5.2