From: Kevin Wolf <kwolf@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com
Subject: [Qemu-devel] [PATCH 3/3] qcow2: Return real error code in load_refcount_block
Date: Fri, 4 Jun 2010 12:19:12 +0200 [thread overview]
Message-ID: <1275646752-25763-4-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1275646752-25763-1-git-send-email-kwolf@redhat.com>
This fixes load_refcount_block which completely ignored the return value of
write_refcount_block and always returned -EIO for bdrv_pwrite failure.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block/qcow2-refcount.c | 11 ++++++++---
1 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index 51948ae..41e1da9 100644
--- a/block/qcow2-refcount.c
+++ b/block/qcow2-refcount.c
@@ -93,14 +93,19 @@ static int load_refcount_block(BlockDriverState *bs,
int ret;
if (cache_refcount_updates) {
- write_refcount_block(bs);
+ ret = write_refcount_block(bs);
+ if (ret < 0) {
+ return ret;
+ }
}
BLKDBG_EVENT(bs->file, BLKDBG_REFBLOCK_LOAD);
ret = bdrv_pread(bs->file, refcount_block_offset, s->refcount_block_cache,
s->cluster_size);
- if (ret != s->cluster_size)
- return -EIO;
+ if (ret < 0) {
+ return ret;
+ }
+
s->refcount_block_cache_offset = refcount_block_offset;
return 0;
}
--
1.6.6.1
prev parent reply other threads:[~2010-06-04 10:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-04 10:19 [Qemu-devel] [PATCH 0/3] qcow2: More error handling fixes Kevin Wolf
2010-06-04 10:19 ` [Qemu-devel] [PATCH 1/3] qcow2: Allow get_refcount to return errors Kevin Wolf
2010-06-04 10:19 ` [Qemu-devel] [PATCH 2/3] qcow2: Allow alloc_clusters_noref " Kevin Wolf
2010-06-04 10:19 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275646752-25763-4-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).