qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Corentin Chary <corentincj@iksaif.net>
To: Qemu-development List <qemu-devel@nongnu.org>
Cc: Corentin Chary <corentincj@iksaif.net>,
	Anthony Liguori <aliguori@linux.vnet.ibm.com>,
	Alexander Graf <agraf@suse.de>
Subject: [Qemu-devel] [PATCH 3/5] vnc: add lossless option
Date: Fri,  4 Jun 2010 15:18:45 +0200	[thread overview]
Message-ID: <1275657527-26032-4-git-send-email-corentincj@iksaif.net> (raw)
In-Reply-To: <1275657527-26032-1-git-send-email-corentincj@iksaif.net>

The lossless option can be used to force lossless compression
by disabling all lossy encodings like gradient or jpeg.

Signed-off-by: Corentin Chary <corentincj@iksaif.net>
---
 qemu-options.hx      |    5 +++++
 vnc-encoding-tight.c |    4 ++++
 vnc.c                |    2 ++
 vnc.h                |    2 ++
 4 files changed, 13 insertions(+), 0 deletions(-)

diff --git a/qemu-options.hx b/qemu-options.hx
index a6928b7..81fd737 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -828,6 +828,11 @@ empty, with a @code{deny} policy. Thus no one will be allowed to
 use the VNC server until the ACLs have been loaded. This can be
 achieved using the @code{acl} monitor command.
 
+@item lossless
+
+Turn off all lossy compression methods (gradient, JPEG, ...). If this
+option is set, VNC client will only receive lossless framebuffer updates.
+
 @end table
 ETEXI
 
diff --git a/vnc-encoding-tight.c b/vnc-encoding-tight.c
index 495745e..51bb707 100644
--- a/vnc-encoding-tight.c
+++ b/vnc-encoding-tight.c
@@ -230,6 +230,10 @@ tight_detect_smooth_image(VncState *vs, int w, int h)
     int compression = vs->tight_compression;
     int quality = vs->tight_quality;
 
+    if (vs->vd->lossless) {
+        return 0;
+    }
+
     if (ds_get_bytes_per_pixel(vs->ds) == 1 ||
         vs->clientds.pf.bytes_per_pixel == 1 ||
         w < VNC_TIGHT_DETECT_MIN_WIDTH || h < VNC_TIGHT_DETECT_MIN_HEIGHT) {
diff --git a/vnc.c b/vnc.c
index 9cf38d1..e3ef315 100644
--- a/vnc.c
+++ b/vnc.c
@@ -2482,6 +2482,8 @@ int vnc_display_open(DisplayState *ds, const char *display)
 #endif
         } else if (strncmp(options, "acl", 3) == 0) {
             acl = 1;
+        } else if (strncmp(options, "lossless", 8) == 0) {
+            vs->lossless = true;
         }
     }
 
diff --git a/vnc.h b/vnc.h
index 2a9024d..cca1946 100644
--- a/vnc.h
+++ b/vnc.h
@@ -33,6 +33,7 @@
 #include "monitor.h"
 #include "audio/audio.h"
 #include <zlib.h>
+#include <stdbool.h>
 
 #include "keymaps.h"
 
@@ -111,6 +112,7 @@ struct VncDisplay
     char *display;
     char *password;
     int auth;
+    bool lossless;
 #ifdef CONFIG_VNC_TLS
     int subauth; /* Used by VeNCrypt */
     VncDisplayTLS tls;
-- 
1.7.1

  parent reply	other threads:[~2010-06-04 13:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-04 13:18 [Qemu-devel] [PATCH 0/5] vnc updates and ui move Corentin Chary
     [not found] ` <1275657527-26032-5-git-send-email-corentincj@iksaif.net>
2010-06-04 13:18   ` [Qemu-devel] Re: [PATCH 4/5] ui: move all ui components in ui/ Alexander Graf
2010-06-04 14:23     ` Corentin Chary
2010-06-04 13:18 ` [Qemu-devel] [PATCH 1/5] vnc: tight: add JPEG and gradient subencoding with smooth image detection Corentin Chary
2010-06-04 13:18 ` [Qemu-devel] [PATCH 2/5] vnc: JPEG should be disabled if the client don't set tight quality Corentin Chary
2010-06-04 13:16   ` [Qemu-devel] " Alexander Graf
2010-06-04 13:19     ` Anthony Liguori
2010-06-04 13:20       ` Alexander Graf
2010-06-04 13:48         ` Corentin Chary
2010-06-04 13:52           ` Alexander Graf
2010-06-04 14:22             ` Corentin Chary
2010-06-04 13:18 ` Corentin Chary [this message]
2010-06-04 13:17   ` [Qemu-devel] Re: [PATCH 3/5] vnc: add lossless option Alexander Graf
2010-06-04 13:20     ` Anthony Liguori
2010-06-04 13:18 ` [Qemu-devel] [PATCH 5/5] vnc: rename vnc-encoding-* vnc-enc-* Corentin Chary
2010-06-04 13:18   ` [Qemu-devel] " Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1275657527-26032-4-git-send-email-corentincj@iksaif.net \
    --to=corentincj@iksaif.net \
    --cc=agraf@suse.de \
    --cc=aliguori@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).