From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 17/27] ide: Fix info qtree for ide-drive.ver
Date: Fri, 4 Jun 2010 18:33:05 +0200 [thread overview]
Message-ID: <1275669195-28312-18-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1275669195-28312-1-git-send-email-kwolf@redhat.com>
From: Markus Armbruster <armbru@redhat.com>
Show the actual default value instead of <null> when the property has
not been set.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
hw/ide/qdev.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c
index 5e549d9..6231d77 100644
--- a/hw/ide/qdev.c
+++ b/hw/ide/qdev.c
@@ -110,6 +110,9 @@ static int ide_drive_initfn(IDEDevice *dev)
ide_init_drive(s, dev->conf.dinfo, dev->version, serial);
+ if (!dev->version) {
+ dev->version = qemu_strdup(s->version);
+ }
if (!dev->serial) {
dev->serial = qemu_strdup(s->drive_serial_str);
}
--
1.6.6.1
next prev parent reply other threads:[~2010-06-04 16:37 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-04 16:32 [Qemu-devel] [PULL 00/27] Block patches Kevin Wolf
2010-06-04 16:32 ` [Qemu-devel] [PATCH 01/27] Cleanup: bdrv_open() no need to shift total_size just to shift back Kevin Wolf
2010-06-04 16:32 ` [Qemu-devel] [PATCH 02/27] Cleanup: Be consistent and use BDRV_SECTOR_SIZE instead of 512 Kevin Wolf
2010-06-04 16:32 ` [Qemu-devel] [PATCH 03/27] Cleanup: raw-posix.c: Be more consistent using " Kevin Wolf
2010-06-04 16:32 ` [Qemu-devel] [PATCH 04/27] Cleanup: virtio-blk.c: Be more consistent using BDRV_SECTOR_SIZE instead Kevin Wolf
2010-06-04 16:32 ` [Qemu-devel] [PATCH 05/27] qemu-io: Fix error messages Kevin Wolf
2010-06-04 16:32 ` [Qemu-devel] [PATCH 06/27] blockdev: Belatedly remove MAX_DRIVES Kevin Wolf
2010-06-04 16:32 ` [Qemu-devel] [PATCH 07/27] blockdev: Belatedly remove driveopts Kevin Wolf
2010-06-04 16:32 ` [Qemu-devel] [PATCH 08/27] usb: Remove unused usb_device_add() parameter is_hotplug Kevin Wolf
2010-06-04 16:32 ` [Qemu-devel] [PATCH 09/27] ide: Remove useless IDEDeviceInfo members unit, drive Kevin Wolf
2010-06-04 16:32 ` [Qemu-devel] [PATCH 10/27] ide: Remove redundant IDEState member conf Kevin Wolf
2010-06-04 16:32 ` [Qemu-devel] [PATCH 11/27] ide: Split ide_init1() off ide_init2() Kevin Wolf
2010-06-04 16:33 ` [Qemu-devel] [PATCH 12/27] ide: Change ide_init_drive() to require valid dinfo argument Kevin Wolf
2010-06-04 16:33 ` [Qemu-devel] [PATCH 13/27] ide: Split non-qdev code off ide_init2() Kevin Wolf
2010-06-04 16:33 ` [Qemu-devel] [PATCH 14/27] qdev: New qdev_prop_set_string() Kevin Wolf
2010-06-04 16:33 ` [Qemu-devel] [PATCH 15/27] qdev: Don't leak string property value on hot unplug Kevin Wolf
2010-06-04 16:33 ` [Qemu-devel] [PATCH 16/27] ide: Turn drive serial into a qdev property ide-drive.serial Kevin Wolf
2010-06-04 16:33 ` Kevin Wolf [this message]
2010-06-04 16:33 ` [Qemu-devel] [PATCH 18/27] scsi: Turn drive serial into a qdev property scsi-disk.serial Kevin Wolf
2010-06-04 16:33 ` [Qemu-devel] [PATCH 19/27] scsi: Fix info qtree for scsi-disk.ver Kevin Wolf
2010-06-04 16:33 ` [Qemu-devel] [PATCH 20/27] Fix error message in drive_init Kevin Wolf
2010-06-04 16:33 ` [Qemu-devel] [PATCH 21/27] block: Assume raw for drives without media Kevin Wolf
2010-06-04 16:33 ` [Qemu-devel] [PATCH 22/27] close all the block drivers before the qemu process exits Kevin Wolf
2010-06-04 16:33 ` [Qemu-devel] [PATCH 23/27] block: call the snapshot handlers of the protocol drivers Kevin Wolf
2010-06-04 16:33 ` [Qemu-devel] [PATCH 24/27] blockdev: Hide QEMUMachine from drive_init() Kevin Wolf
2010-06-04 16:33 ` [Qemu-devel] [PATCH 25/27] qdev: Move declaration of qdev_init_bdrv() into qdev.h Kevin Wolf
2010-06-04 16:33 ` [Qemu-devel] [PATCH 26/27] blockdev: Collect block device code in new blockdev.c Kevin Wolf
2010-12-15 15:04 ` Artyom Tarasenko
2010-12-15 15:31 ` Kevin Wolf
2012-05-17 9:15 ` Artyom Tarasenko
2010-06-04 16:33 ` [Qemu-devel] [PATCH 27/27] block: Fix serial number assignment Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275669195-28312-18-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).