From: Jes.Sorensen@redhat.com
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, shavivi@redhat.com, qemu-devel@nongnu.org,
Jes Sorensen <Jes.Sorensen@redhat.com>
Subject: [Qemu-devel] [PATCH v2] un-register kbd driver for USB kbd unplug
Date: Tue, 8 Jun 2010 15:12:17 +0200 [thread overview]
Message-ID: <1276002738-821-1-git-send-email-Jes.Sorensen@redhat.com> (raw)
From: Jes Sorensen <Jes.Sorensen@redhat.com>
Hi,
Kevin pointed out the TODO comment was obsolete and also suggested
turning the if lines into a switch statement. It seems cleaner, so
here is a second version of the patch.
This is a fairly simple fix for the problem where the keyboard event
handler is left in place when a keyboard is unplugged, eg. USB.
The long term solution would be to use Shahar Havivi's multi-keyboard
support patch[1] from March, but until Shahar's patch is ready, this one
fixes the current crash problem.
Cheers,
Jes
[1]: http://www.mail-archive.com/qemu-devel@nongnu.org/msg28589.html
Jes Sorensen (1):
un-register kbd driver in case of USB kbd unplug.
console.h | 1 +
hw/usb-hid.c | 8 ++++++--
input.c | 6 ++++++
3 files changed, 13 insertions(+), 2 deletions(-)
next reply other threads:[~2010-06-08 13:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-08 13:12 Jes.Sorensen [this message]
2010-06-08 13:12 ` [Qemu-devel] [PATCH] un-register kbd driver in case of USB kbd unplug Jes.Sorensen
2010-06-09 7:52 ` Markus Armbruster
2010-06-14 20:57 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276002738-821-1-git-send-email-Jes.Sorensen@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=shavivi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).