From: Alex Williamson <alex.williamson@redhat.com>
To: qemu-devel@nongnu.org
Cc: chrisw@redhat.com, kvm@vger.kernel.org, quintela@redhat.com
Subject: [Qemu-devel] Re: [RFC PATCH 7/6] savevm: Create a new continue flag to avoid resending block name
Date: Tue, 08 Jun 2010 15:32:46 -0600 [thread overview]
Message-ID: <1276032766.3079.18.camel@x201> (raw)
In-Reply-To: <20100608211131.10053.73203.stgit@localhost.localdomain>
On Tue, 2010-06-08 at 15:11 -0600, Alex Williamson wrote:
> Allows us to compress the protocol a bit.
...
> @@ -284,6 +290,33 @@ int ram_save_live(Monitor *mon, QEMUFile *f, int stage, void *opaque)
> return (stage == 2) && (expected_time <= migrate_max_downtime());
> }
>
> +static inline void *host_from_stream_offset(QEMUFile *f,
> + ram_addr_t offset,
> + int flags)
This probably shouldn't be inline. When sending, we'll continue from
COMPRESS or PAGE. We'd get out of sync on the recv if the compiler
created separate static blocks. Compiler folks correct me if this can't
happen.
Alex
next prev parent reply other threads:[~2010-06-08 21:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0100608191447.4451.47795.stgit@localhost.localdomain>
2010-06-08 21:11 ` [Qemu-devel] [RFC PATCH 7/6] savevm: Create a new continue flag to avoid resending block name Alex Williamson
2010-06-08 21:32 ` Alex Williamson [this message]
2010-06-08 22:29 ` [Qemu-devel] " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276032766.3079.18.camel@x201 \
--to=alex.williamson@redhat.com \
--cc=chrisw@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).