From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=49915 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OMeHx-0005Z6-6p for qemu-devel@nongnu.org; Thu, 10 Jun 2010 05:43:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OMeHv-0001qk-UQ for qemu-devel@nongnu.org; Thu, 10 Jun 2010 05:43:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27617) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMeHv-0001qV-Mv for qemu-devel@nongnu.org; Thu, 10 Jun 2010 05:43:03 -0400 From: Jes.Sorensen@redhat.com Date: Thu, 10 Jun 2010 11:42:27 +0200 Message-Id: <1276162951-842-14-git-send-email-Jes.Sorensen@redhat.com> In-Reply-To: <1276162951-842-1-git-send-email-Jes.Sorensen@redhat.com> References: <1276162951-842-1-git-send-email-Jes.Sorensen@redhat.com> Subject: [Qemu-devel] [PATCH 13/17] Move chroot handling to OS specific files. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: Jes Sorensen , qemu-devel@nongnu.org From: Jes Sorensen Move chroot handling to OS specific files. Signed-off-by: Jes Sorensen Acked-by: Juan Quintela Acked-by: Richard Henderson --- os-posix.c | 19 +++++++++++++++++++ qemu-os-posix.h | 1 + qemu-os-win32.h | 1 + vl.c | 18 +----------------- 4 files changed, 22 insertions(+), 17 deletions(-) diff --git a/os-posix.c b/os-posix.c index 8b686a4..6417d16 100644 --- a/os-posix.c +++ b/os-posix.c @@ -38,6 +38,7 @@ #include "qemu-options.h" static struct passwd *user_pwd; +static const char *chroot_dir; void os_setup_early_signal_handling(void) { @@ -156,6 +157,9 @@ void os_parse_cmd_args(int index, const char *optarg) exit(1); } break; + case QEMU_OPTION_chroot: + chroot_dir = optarg; + break; } return; } @@ -177,3 +181,18 @@ void os_change_process_uid(void) } } } + +void os_change_root(void) +{ + if (chroot_dir) { + if (chroot(chroot_dir) < 0) { + fprintf(stderr, "chroot failed\n"); + exit(1); + } + if (chdir("/")) { + perror("not able to chdir to /"); + exit(1); + } + } + +} diff --git a/qemu-os-posix.h b/qemu-os-posix.h index 6d8cf79..91c7b68 100644 --- a/qemu-os-posix.h +++ b/qemu-os-posix.h @@ -32,5 +32,6 @@ static inline void os_host_main_loop_wait(int *timeout) void os_setup_signal_handling(void); void os_change_process_uid(void); +void os_change_root(void); #endif diff --git a/qemu-os-win32.h b/qemu-os-win32.h index 70fdca5..e2a97d2 100644 --- a/qemu-os-win32.h +++ b/qemu-os-win32.h @@ -44,5 +44,6 @@ void os_host_main_loop_wait(int *timeout); static inline void os_setup_signal_handling(void) {} static inline void os_change_process_uid(void) {} +static inline void os_change_root(void) {} #endif diff --git a/vl.c b/vl.c index 4b76e2d..c5f0e63 100644 --- a/vl.c +++ b/vl.c @@ -2309,7 +2309,6 @@ int main(int argc, char **argv, char **envp) const char *incoming = NULL; #ifndef _WIN32 int fd = 0; - const char *chroot_dir = NULL; #endif int show_vnc_port = 0; int defconfig = 1; @@ -3053,11 +3052,6 @@ int main(int argc, char **argv, char **envp) default_cdrom = 0; default_sdcard = 0; break; -#ifndef _WIN32 - case QEMU_OPTION_chroot: - chroot_dir = optarg; - break; -#endif case QEMU_OPTION_xen_domid: if (!(xen_available())) { printf("Option %s not supported for this target\n", popt->name); @@ -3547,17 +3541,7 @@ int main(int argc, char **argv, char **envp) exit(1); } - if (chroot_dir) { - if (chroot(chroot_dir) < 0) { - fprintf(stderr, "chroot failed\n"); - exit(1); - } - if (chdir("/")) { - perror("not able to chdir to /"); - exit(1); - } - } - + os_change_root(); os_change_process_uid(); if (daemonize) { -- 1.6.5.2