From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=42450 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OMipG-0001v5-Ja
	for qemu-devel@nongnu.org; Thu, 10 Jun 2010 10:33:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <alex.williamson@redhat.com>) id 1OMipC-0001GH-7T
	for qemu-devel@nongnu.org; Thu, 10 Jun 2010 10:33:46 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60955)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <alex.williamson@redhat.com>) id 1OMipB-0001G1-To
	for qemu-devel@nongnu.org; Thu, 10 Jun 2010 10:33:42 -0400
Subject: Re: [Qemu-devel] [RFC PATCH 3/6] RAMBlock: Add a name field
From: Alex Williamson <alex.williamson@redhat.com>
In-Reply-To: <4C10A106.1050108@redhat.com>
References: <20100608191447.4451.47795.stgit@localhost.localdomain>
	<201006091318.49556.paul@codesourcery.com>
	<1276101449.3079.74.camel@x201>
	<201006092136.38569.paul@codesourcery.com>
	<4C10A106.1050108@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Date: Thu, 10 Jun 2010 08:33:28 -0600
Message-ID: <1276180408.2992.12.camel@x201>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: chrisw@redhat.com, kvm@vger.kernel.org, quintela@redhat.com, qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>

On Thu, 2010-06-10 at 10:23 +0200, Gerd Hoffmann wrote:
> > I may have been a bit misleading here. What we really want to do is use the
> > same matching algorithm as is used by the rest of the device state. Currently
> > this is a vmstate name and [arbitrary] numeric id. I don't remember whether
> > there's a convenient link from a device to its associated vmstate - if there
> > isn't there probably should be.
> 
> DeviceState->info->vmsd->name for the name.
> Dunno about the numeric id, I think savevm.c doesn't export it.

Ok, we can certainly do <vmsd->name>.<vmsd->instance>\<driver string>.
It seems like this highlights a deficiency in the vmstate matching
though.  If on the source we do:

> pci_add addr=4 nic model=e1000
> pci_add addr=3 nic model=e1000

Then we start the target, ordering the nics sequentially, are we going
to store the vmstate into the opposite nics?  AIUI, libvirt does this
correctly today, but I don't like the idea of being required to remember
the history of a vm to migrate it.

Alex