From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=55214 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OMoNc-0002T9-Fh for qemu-devel@nongnu.org; Thu, 10 Jun 2010 16:29:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OMoNZ-0001Yz-7D for qemu-devel@nongnu.org; Thu, 10 Jun 2010 16:29:34 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:38554) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMoNZ-0001Yc-0B for qemu-devel@nongnu.org; Thu, 10 Jun 2010 16:29:33 -0400 Received: from d03relay01.boulder.ibm.com (d03relay01.boulder.ibm.com [9.17.195.226]) by e39.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id o5AKKO2u006362 for ; Thu, 10 Jun 2010 14:20:24 -0600 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay01.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o5AKTHdf108898 for ; Thu, 10 Jun 2010 14:29:19 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id o5AKTHMG019760 for ; Thu, 10 Jun 2010 14:29:17 -0600 From: "Venkateswararao Jujjuri (JV)" Date: Thu, 10 Jun 2010 13:32:54 -0700 Message-Id: <1276201979-17825-6-git-send-email-jvrao@linux.vnet.ibm.com> In-Reply-To: <1276201979-17825-1-git-send-email-jvrao@linux.vnet.ibm.com> References: <1276201979-17825-1-git-send-email-jvrao@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH-V6 05/10] virtio-9p: Implemented Security model for lstat and fstat List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com, "Venkateswararao Jujjuri (JV)" Signed-off-by: Venkateswararao Jujjuri --- hw/virtio-9p-local.c | 62 ++++++++++++++++++++++++++++++++++++++++++++++--- 1 files changed, 58 insertions(+), 4 deletions(-) diff --git a/hw/virtio-9p-local.c b/hw/virtio-9p-local.c index 1d7cb32..74c81a6 100644 --- a/hw/virtio-9p-local.c +++ b/hw/virtio-9p-local.c @@ -27,9 +27,38 @@ static const char *rpath(FsContext *ctx, const char *path) return buffer; } -static int local_lstat(FsContext *ctx, const char *path, struct stat *stbuf) + +static int local_lstat(FsContext *fs_ctx, const char *path, struct stat *stbuf) { - return lstat(rpath(ctx, path), stbuf); + int err; + err = lstat(rpath(fs_ctx, path), stbuf); + if (err) { + return err; + } + if (fs_ctx->fs_sm == SM_MAPPED) { + /* Actual credentials are part of extended attrs */ + uid_t tmp_uid; + gid_t tmp_gid; + mode_t tmp_mode; + dev_t tmp_dev; + if (getxattr(rpath(fs_ctx, path), "user.virtfs.uid", &tmp_uid, + sizeof(uid_t)) > 0) { + stbuf->st_uid = tmp_uid; + } + if (getxattr(rpath(fs_ctx, path), "user.virtfs.gid", &tmp_gid, + sizeof(gid_t)) > 0) { + stbuf->st_gid = tmp_gid; + } + if (getxattr(rpath(fs_ctx, path), "user.virtfs.mode", &tmp_mode, + sizeof(mode_t)) > 0) { + stbuf->st_mode = tmp_mode; + } + if (getxattr(rpath(fs_ctx, path), "user.virtfs.rdev", &tmp_dev, + sizeof(dev_t)) > 0) { + stbuf->st_rdev = tmp_dev; + } + } + return err; } static int local_set_xattr(const char *path, FsCred *credp) @@ -171,9 +200,34 @@ static int local_mkdir(FsContext *ctx, const char *path, mode_t mode) return mkdir(rpath(ctx, path), mode); } -static int local_fstat(FsContext *ctx, int fd, struct stat *stbuf) +static int local_fstat(FsContext *fs_ctx, int fd, struct stat *stbuf) { - return fstat(fd, stbuf); + int err; + err = fstat(fd, stbuf); + if (err) { + return err; + } + if (fs_ctx->fs_sm == SM_MAPPED) { + /* Actual credentials are part of extended attrs */ + uid_t tmp_uid; + gid_t tmp_gid; + mode_t tmp_mode; + dev_t tmp_dev; + + if (fgetxattr(fd, "user.virtfs.uid", &tmp_uid, sizeof(uid_t)) > 0) { + stbuf->st_uid = tmp_uid; + } + if (fgetxattr(fd, "user.virtfs.gid", &tmp_gid, sizeof(gid_t)) > 0) { + stbuf->st_gid = tmp_gid; + } + if (fgetxattr(fd, "user.virtfs.mode", &tmp_mode, sizeof(mode_t)) > 0) { + stbuf->st_mode = tmp_mode; + } + if (fgetxattr(fd, "user.virtfs.rdev", &tmp_dev, sizeof(dev_t)) > 0) { + stbuf->st_rdev = tmp_dev; + } + } + return err; } static int local_open2(FsContext *ctx, const char *path, int flags, mode_t mode) -- 1.6.5.2