From: Luiz Capitulino <lcapitulino@redhat.com>
To: aliguori@us.ibm.com
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 04/10] check-qjson: Add more escape tests
Date: Fri, 11 Jun 2010 16:58:09 -0300 [thread overview]
Message-ID: <1276286295-17601-5-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1276286295-17601-1-git-send-email-lcapitulino@redhat.com>
While there make the fail_unless() calls print error messages.
IMPORTANT: The test for "\/" is failing, don't know why.
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
check-qjson.c | 14 ++++++++++++--
1 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/check-qjson.c b/check-qjson.c
index 109e777..d365799 100644
--- a/check-qjson.c
+++ b/check-qjson.c
@@ -29,6 +29,13 @@ START_TEST(escaped_string)
const char *decoded;
int skip;
} test_cases[] = {
+ { "\"\\b\"", "\b" },
+ { "\"\\f\"", "\f" },
+ { "\"\\n\"", "\n" },
+ { "\"\\r\"", "\r" },
+ { "\"\\t\"", "\t" },
+ { "\"\\/\"", "\\/" },
+ { "\"\\\\\"", "\\" },
{ "\"\\\"\"", "\"" },
{ "\"hello world \\\"embedded string\\\"\"",
"hello world \"embedded string\"" },
@@ -49,11 +56,14 @@ START_TEST(escaped_string)
fail_unless(qobject_type(obj) == QTYPE_QSTRING);
str = qobject_to_qstring(obj);
- fail_unless(strcmp(qstring_get_str(str), test_cases[i].decoded) == 0);
+ fail_unless(strcmp(qstring_get_str(str), test_cases[i].decoded) == 0,
+ "%s != %s\n", qstring_get_str(str), test_cases[i].decoded);
if (test_cases[i].skip == 0) {
str = qobject_to_json(obj);
- fail_unless(strcmp(qstring_get_str(str), test_cases[i].encoded) == 0);
+ fail_unless(strcmp(qstring_get_str(str),test_cases[i].encoded) == 0,
+ "%s != %s\n", qstring_get_str(str),
+ test_cases[i].encoded);
qobject_decref(obj);
}
--
1.7.1.251.g92a7
next prev parent reply other threads:[~2010-06-11 19:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-11 19:58 [Qemu-devel] [PATCH 00/10][PULL]: QMP/Monitor queue Luiz Capitulino
2010-06-11 19:58 ` [Qemu-devel] [PATCH 01/10] json-lexer: Initialize 'x' and 'y' Luiz Capitulino
2010-06-11 19:58 ` [Qemu-devel] [PATCH 02/10] json-lexer: Handle missing escapes Luiz Capitulino
2010-06-11 19:58 ` [Qemu-devel] [PATCH 03/10] qjson: Handle "\f" Luiz Capitulino
2010-06-11 19:58 ` Luiz Capitulino [this message]
2010-06-11 19:58 ` [Qemu-devel] [PATCH 05/10] json-lexer: Drop 'buf' Luiz Capitulino
2010-06-11 19:58 ` [Qemu-devel] [PATCH 06/10] json-streamer: Don't use qdict_put_obj() Luiz Capitulino
2010-06-11 19:58 ` [Qemu-devel] [PATCH 07/10] add some tests for invalid JSON Luiz Capitulino
2010-06-11 19:58 ` [Qemu-devel] [PATCH 08/10] implement optional lookahead in json lexer Luiz Capitulino
2010-06-11 19:58 ` [Qemu-devel] [PATCH 09/10] remove unnecessary lookaheads Luiz Capitulino
2010-06-11 19:58 ` [Qemu-devel] [PATCH 10/10] hxtool: Fix line number reporting on SQMP/EQMP errors Luiz Capitulino
2010-06-14 15:54 ` [Qemu-devel] [PATCH 00/10][PULL]: QMP/Monitor queue Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276286295-17601-5-git-send-email-lcapitulino@redhat.com \
--to=lcapitulino@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).