qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: aliguori@us.ibm.com
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 05/10] json-lexer: Drop 'buf'
Date: Fri, 11 Jun 2010 16:58:10 -0300	[thread overview]
Message-ID: <1276286295-17601-6-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1276286295-17601-1-git-send-email-lcapitulino@redhat.com>

QString supports adding a single char, 'buf' is unneeded.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 json-lexer.c |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)

diff --git a/json-lexer.c b/json-lexer.c
index 5cc7e6c..1d9b81f 100644
--- a/json-lexer.c
+++ b/json-lexer.c
@@ -284,8 +284,6 @@ void json_lexer_init(JSONLexer *lexer, JSONLexerEmitter func)
 
 static int json_lexer_feed_char(JSONLexer *lexer, char ch)
 {
-    char buf[2];
-
     lexer->x++;
     if (ch == '\n') {
         lexer->x = 0;
@@ -313,10 +311,7 @@ static int json_lexer_feed_char(JSONLexer *lexer, char ch)
         break;
     }
 
-    buf[0] = ch;
-    buf[1] = 0;
-
-    qstring_append(lexer->token, buf);
+    qstring_append_chr(lexer->token, ch);
 
     return 0;
 }
-- 
1.7.1.251.g92a7

  parent reply	other threads:[~2010-06-11 19:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-11 19:58 [Qemu-devel] [PATCH 00/10][PULL]: QMP/Monitor queue Luiz Capitulino
2010-06-11 19:58 ` [Qemu-devel] [PATCH 01/10] json-lexer: Initialize 'x' and 'y' Luiz Capitulino
2010-06-11 19:58 ` [Qemu-devel] [PATCH 02/10] json-lexer: Handle missing escapes Luiz Capitulino
2010-06-11 19:58 ` [Qemu-devel] [PATCH 03/10] qjson: Handle "\f" Luiz Capitulino
2010-06-11 19:58 ` [Qemu-devel] [PATCH 04/10] check-qjson: Add more escape tests Luiz Capitulino
2010-06-11 19:58 ` Luiz Capitulino [this message]
2010-06-11 19:58 ` [Qemu-devel] [PATCH 06/10] json-streamer: Don't use qdict_put_obj() Luiz Capitulino
2010-06-11 19:58 ` [Qemu-devel] [PATCH 07/10] add some tests for invalid JSON Luiz Capitulino
2010-06-11 19:58 ` [Qemu-devel] [PATCH 08/10] implement optional lookahead in json lexer Luiz Capitulino
2010-06-11 19:58 ` [Qemu-devel] [PATCH 09/10] remove unnecessary lookaheads Luiz Capitulino
2010-06-11 19:58 ` [Qemu-devel] [PATCH 10/10] hxtool: Fix line number reporting on SQMP/EQMP errors Luiz Capitulino
2010-06-14 15:54 ` [Qemu-devel] [PATCH 00/10][PULL]: QMP/Monitor queue Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1276286295-17601-6-git-send-email-lcapitulino@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).