From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Kevin Wolf <kwolf@redhat.com>, kvm-devel <kvm@vger.kernel.org>,
Hannes Reinecke <hare@suse.de>,
qemu-devel <qemu-devel@nongnu.org>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
Paul Brook <paul@codesourcery.com>,
Christoph Hellwig <hch@lst.de>, Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] Re: [PATCH 3/5] [block]: Add paio_submit_len() non sector sized AIO
Date: Mon, 14 Jun 2010 05:14:30 -0700 [thread overview]
Message-ID: <1276517670.7768.4.camel@haakon2.linux-iscsi.org> (raw)
In-Reply-To: <20100614114256.GA31653@infradead.org>
On Mon, 2010-06-14 at 07:42 -0400, Christoph Hellwig wrote:
> On Mon, Jun 14, 2010 at 02:44:31AM -0700, Nicholas A. Bellinger wrote:
> > From: Nicholas Bellinger <nab@linux-iscsi.org>
> >
> > This patch adds posix-aio-compat.c:paio_submit_len(), which is a identical
> > to paio_submit() expect that in expected nb_len instead of nb_sectors (* 512)
> > so that it can be used by BSG AIO for write()/read() of struct sg_io_v4.
>
> Jusre remove the nb_sectors argument, we already get the length passed
> in the iovec.
>
Mmmm, should this stay in a seperate paio_submit_len() function..? Or
would it be preferred to calculate struct qemu_paiocb->aio_nbytes from
the passed iov[i].iov_len for the BlockDriverState->sg == BDS_BSG
case..?
Best,
--nab
prev parent reply other threads:[~2010-06-14 12:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-14 9:44 [Qemu-devel] [PATCH 3/5] [block]: Add paio_submit_len() non sector sized AIO Nicholas A. Bellinger
2010-06-14 11:42 ` [Qemu-devel] " Christoph Hellwig
2010-06-14 12:14 ` Nicholas A. Bellinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276517670.7768.4.camel@haakon2.linux-iscsi.org \
--to=nab@linux-iscsi.org \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).