From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=51004 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OOFJi-0006PW-7e for qemu-devel@nongnu.org; Mon, 14 Jun 2010 15:27:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OOFJh-0002QU-52 for qemu-devel@nongnu.org; Mon, 14 Jun 2010 15:27:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43219) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OOFJg-0002QI-Ug for qemu-devel@nongnu.org; Mon, 14 Jun 2010 15:27:29 -0400 From: Glauber Costa Date: Mon, 14 Jun 2010 16:27:24 -0300 Message-Id: <1276543644-32689-1-git-send-email-glommer@redhat.com> Subject: [Qemu-devel] [PATCH] stop cpus before forking. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com, avi@redhat.com This patch fixes a bug that happens with kvm, irqchip-in-kernel, while adding a netdev. Despite the situations of reproduction being specific to kvm, I believe this fix is pretty generic, and fits here. Specially if we ever want to have our own irqchip in kernel too. The problem happens after the fork system call, and although it is not 100 % reproduceable, happens pretty often. After fork, the memory where the apic is mapped is present in both processes. It ends up confusing the vcpus somewhere in the irq <-> ack path, and qemu hangs, with no irqs being delivered at all from that point on. Making sure the vcpus are stopped before forking makes the problem go away. Besides, this is a pretty unfrequent operation, which already hangs the io-thread for a while. So it should not hurt performance. Signed-off-by: Glauber Costa --- net/tap.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/net/tap.c b/net/tap.c index 0147dab..f34dd9c 100644 --- a/net/tap.c +++ b/net/tap.c @@ -330,6 +330,9 @@ static int launch_script(const char *setup_script, const char *ifname, int fd) sigaddset(&mask, SIGCHLD); sigprocmask(SIG_BLOCK, &mask, &oldmask); + /* make sure no cpus are running, so the apic does not + * get confused */ + vm_stop(0); /* try to launch network script */ pid = fork(); if (pid == 0) { @@ -350,6 +353,7 @@ static int launch_script(const char *setup_script, const char *ifname, int fd) execv(setup_script, args); _exit(1); } else if (pid > 0) { + vm_start(); while (waitpid(pid, &status, 0) != pid) { /* loop */ } -- 1.7.0.1