From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=37928 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OOX07-0008GX-8H for qemu-devel@nongnu.org; Tue, 15 Jun 2010 10:20:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OOX02-0000Ch-6y for qemu-devel@nongnu.org; Tue, 15 Jun 2010 10:20:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40857) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OOX01-0000CU-Ti for qemu-devel@nongnu.org; Tue, 15 Jun 2010 10:20:22 -0400 From: Kevin Wolf Date: Tue, 15 Jun 2010 16:19:38 +0200 Message-Id: <1276611581-3757-17-git-send-email-kwolf@redhat.com> In-Reply-To: <1276611581-3757-1-git-send-email-kwolf@redhat.com> References: <1276611581-3757-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 16/19] blockdev: Give drives internal linkage List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org From: Markus Armbruster This is the list of drives defined with drive_init(). Hide it, so it doesn't get abused. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- blockdev.c | 2 +- blockdev.h | 2 -- 2 files changed, 1 insertions(+), 3 deletions(-) diff --git a/blockdev.c b/blockdev.c index f636bc6..b376884 100644 --- a/blockdev.c +++ b/blockdev.c @@ -15,7 +15,7 @@ #include "qemu-config.h" #include "sysemu.h" -struct drivelist drives = QTAILQ_HEAD_INITIALIZER(drives); +static QTAILQ_HEAD(drivelist, DriveInfo) drives = QTAILQ_HEAD_INITIALIZER(drives); QemuOpts *drive_add(const char *file, const char *fmt, ...) { diff --git a/blockdev.h b/blockdev.h index 9e8a7fc..23ea576 100644 --- a/blockdev.h +++ b/blockdev.h @@ -36,8 +36,6 @@ typedef struct DriveInfo { #define MAX_IDE_DEVS 2 #define MAX_SCSI_DEVS 7 -extern QTAILQ_HEAD(drivelist, DriveInfo) drives; - extern DriveInfo *drive_get(BlockInterfaceType type, int bus, int unit); extern DriveInfo *drive_get_by_id(const char *id); extern int drive_get_max_bus(BlockInterfaceType type); -- 1.6.6.1