From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=37766 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OOWzn-00080x-AJ for qemu-devel@nongnu.org; Tue, 15 Jun 2010 10:20:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OOWzl-00007j-Ta for qemu-devel@nongnu.org; Tue, 15 Jun 2010 10:20:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19051) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OOWzl-00007X-N7 for qemu-devel@nongnu.org; Tue, 15 Jun 2010 10:20:05 -0400 From: Kevin Wolf Date: Tue, 15 Jun 2010 16:19:28 +0200 Message-Id: <1276611581-3757-7-git-send-email-kwolf@redhat.com> In-Reply-To: <1276611581-3757-1-git-send-email-kwolf@redhat.com> References: <1276611581-3757-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 06/19] Fix regression for "-drive file=" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org From: Markus Armbruster Empty file used to create an empty drive (no media). Since commit 9dfd7c7a, it's an error: "qemu: could not open disk image : No such file or directory". Older versions of libvirt can choke on this. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- blockdev.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/blockdev.c b/blockdev.c index 642ce75..dbeef09 100644 --- a/blockdev.c +++ b/blockdev.c @@ -462,7 +462,7 @@ DriveInfo *drive_init(QemuOpts *opts, int default_to_scsi, int *fatal_error) case IF_COUNT: abort(); } - if (!file) { + if (!file || !*file) { *fatal_error = 0; return NULL; } -- 1.6.6.1