From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=42338 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OOdIj-0005Ql-Sm for qemu-devel@nongnu.org; Tue, 15 Jun 2010 17:04:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OOdIh-0006BT-TN for qemu-devel@nongnu.org; Tue, 15 Jun 2010 17:04:05 -0400 Received: from moutng.kundenserver.de ([212.227.17.10]:62668) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OOdIh-00063a-Ie for qemu-devel@nongnu.org; Tue, 15 Jun 2010 17:04:03 -0400 From: Stefan Weil Date: Tue, 15 Jun 2010 23:03:28 +0200 Message-Id: <1276635808-7315-1-git-send-email-weil@mail.berlios.de> Subject: [Qemu-devel] [PATCH] Fix comparison which always returned false List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: QEMU Developers Cc: Anthony Liguori , Gleb Natapov Comparing an 8 bit value with ~0 does not work as expected. Replace ~0 by UINT8_MAX in comparison and also in assignment (and fix coding style, too). Cc: Gleb Natapov Cc: Anthony Liguori Signed-off-by: Stefan Weil --- hw/hpet.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/hpet.c b/hw/hpet.c index 0c80ee5..d5c406c 100644 --- a/hw/hpet.c +++ b/hw/hpet.c @@ -74,7 +74,7 @@ typedef struct HPETState { uint8_t hpet_id; /* instance id */ } HPETState; -struct hpet_fw_config hpet_cfg = {.count = ~0}; +struct hpet_fw_config hpet_cfg = {.count = UINT8_MAX}; static uint32_t hpet_in_legacy_mode(HPETState *s) { @@ -682,8 +682,10 @@ static int hpet_init(SysBusDevice *dev) int i, iomemtype; HPETTimer *timer; - if (hpet_cfg.count == ~0) /* first instance */ + if (hpet_cfg.count == UINT8_MAX) { + /* first instance */ hpet_cfg.count = 0; + } if (hpet_cfg.count == 8) { fprintf(stderr, "Only 8 instances of HPET is allowed\n"); -- 1.5.6.5