qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Corentin Chary <corentincj@iksaif.net>
To: qemu-devel@nongnu.org
Cc: Corentin Chary <corentincj@iksaif.net>,
	Anthony Liguori <aliguori@linux.vnet.ibm.com>,
	Alexander Graf <agraf@suse.de>
Subject: [Qemu-devel] [PATCH 16/16] vnc: tight: don't limit png rect size
Date: Wed, 16 Jun 2010 09:12:13 +0200	[thread overview]
Message-ID: <1276672333-14831-17-git-send-email-corentincj@iksaif.net> (raw)
In-Reply-To: <1276672333-14831-1-git-send-email-corentincj@iksaif.net>

PNG was introduced because some vnc HTML5 clients like noVNC
have slow zlib decoding, but really fast PNG rendering. This
means that if PNG is enabled we should send only PNG (and JPEG, fill),
and never something compressed directly with zlib.

Signed-off-by: Corentin Chary <corentincj@iksaif.net>
---
 ui/vnc-enc-tight.c |    4 ----
 ui/vnc-enc-tight.h |    1 -
 2 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
index 1d926c9..e171074 100644
--- a/ui/vnc-enc-tight.c
+++ b/ui/vnc-enc-tight.c
@@ -97,10 +97,6 @@ static bool tight_can_send_png_rect(VncState *vs, int w, int h)
         vs->clientds.pf.bytes_per_pixel == 1) {
         return false;
     }
-
-    if (w * h < VNC_TIGHT_PNG_MIN_RECT_SIZE) {
-        return false;
-    }
     return true;
 }
 #endif
diff --git a/ui/vnc-enc-tight.h b/ui/vnc-enc-tight.h
index dc7150a..a3add78 100644
--- a/ui/vnc-enc-tight.h
+++ b/ui/vnc-enc-tight.h
@@ -176,7 +176,6 @@
 #define VNC_TIGHT_MAX_SPLIT_TILE_SIZE       16
 
 #define VNC_TIGHT_JPEG_MIN_RECT_SIZE      4096
-#define VNC_TIGHT_PNG_MIN_RECT_SIZE       4096
 #define VNC_TIGHT_DETECT_SUBROW_WIDTH        7
 #define VNC_TIGHT_DETECT_MIN_WIDTH           8
 #define VNC_TIGHT_DETECT_MIN_HEIGHT          8
-- 
1.7.1

      parent reply	other threads:[~2010-06-16  6:12 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-16  7:11 [Qemu-devel] [PATCH 00/16] VNC updates for 0.13 Corentin Chary
2010-06-16  7:11 ` [Qemu-devel] [PATCH 01/16] vnc: tight: add JPEG and gradient subencoding with smooth image detection Corentin Chary
2010-06-16 13:18   ` [Qemu-devel] " Juan Quintela
2010-06-16 13:56     ` Corentin Chary
2010-06-16  7:11 ` [Qemu-devel] [PATCH 02/16] vnc: JPEG should be disabled if the client don't set tight quality Corentin Chary
2010-06-16  7:12 ` [Qemu-devel] [PATCH 03/16] vnc: add lossy option Corentin Chary
2010-06-16  7:12 ` [Qemu-devel] [PATCH 04/16] ui: move all ui components in ui/ Corentin Chary
2010-06-16  7:12 ` [Qemu-devel] [PATCH 05/16] vnc: rename vnc-encoding-* vnc-enc-* Corentin Chary
2010-06-16  7:12 ` [Qemu-devel] [PATCH 06/16] vnc: tight: don't forget do at the last color Corentin Chary
2010-06-16  7:12 ` [Qemu-devel] [PATCH 07/16] vnc: tight: remove a memleak in send_jpeg_rect() Corentin Chary
2010-06-16  7:12 ` [Qemu-devel] [PATCH 08/16] vnc: tight add PNG encoding Corentin Chary
2010-06-16  7:12 ` [Qemu-devel] [PATCH 09/16] vnc: tight: specific zlib level and filters for each compression level Corentin Chary
2010-06-16  7:12 ` [Qemu-devel] [PATCH 10/16] vnc: tight: stop using qdict for palette stuff Corentin Chary
2010-06-16  7:12 ` [Qemu-devel] [PATCH 11/16] vnc: encapsulate encoding members Corentin Chary
2010-06-16  7:12 ` [Qemu-devel] [PATCH 12/16] vnc: fix tight png memory leak Corentin Chary
2010-06-16  7:12 ` [Qemu-devel] [PATCH 13/16] qemu-thread: add qemu_mutex/cond_destroy and qemu_mutex_exit Corentin Chary
2010-06-16  7:12 ` [Qemu-devel] [PATCH 14/16] vnc: threaded VNC server Corentin Chary
2010-06-16  7:12 ` [Qemu-devel] [PATCH 15/16] vnc: add missing lock for vnc_cursor_define() Corentin Chary
2010-06-16  7:12 ` Corentin Chary [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1276672333-14831-17-git-send-email-corentincj@iksaif.net \
    --to=corentincj@iksaif.net \
    --cc=agraf@suse.de \
    --cc=aliguori@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).