From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=53378 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OOlr2-0001uc-9J for qemu-devel@nongnu.org; Wed, 16 Jun 2010 02:12:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OOlqx-00033Y-K6 for qemu-devel@nongnu.org; Wed, 16 Jun 2010 02:12:04 -0400 Received: from iksaif.net ([88.191.73.63]:35965) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OOlqx-000338-Fm for qemu-devel@nongnu.org; Wed, 16 Jun 2010 02:11:59 -0400 From: Corentin Chary Date: Wed, 16 Jun 2010 09:12:13 +0200 Message-Id: <1276672333-14831-17-git-send-email-corentincj@iksaif.net> In-Reply-To: <1276672333-14831-1-git-send-email-corentincj@iksaif.net> References: <1276672333-14831-1-git-send-email-corentincj@iksaif.net> Subject: [Qemu-devel] [PATCH 16/16] vnc: tight: don't limit png rect size List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Corentin Chary , Anthony Liguori , Alexander Graf PNG was introduced because some vnc HTML5 clients like noVNC have slow zlib decoding, but really fast PNG rendering. This means that if PNG is enabled we should send only PNG (and JPEG, fill), and never something compressed directly with zlib. Signed-off-by: Corentin Chary --- ui/vnc-enc-tight.c | 4 ---- ui/vnc-enc-tight.h | 1 - 2 files changed, 0 insertions(+), 5 deletions(-) diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c index 1d926c9..e171074 100644 --- a/ui/vnc-enc-tight.c +++ b/ui/vnc-enc-tight.c @@ -97,10 +97,6 @@ static bool tight_can_send_png_rect(VncState *vs, int w, int h) vs->clientds.pf.bytes_per_pixel == 1) { return false; } - - if (w * h < VNC_TIGHT_PNG_MIN_RECT_SIZE) { - return false; - } return true; } #endif diff --git a/ui/vnc-enc-tight.h b/ui/vnc-enc-tight.h index dc7150a..a3add78 100644 --- a/ui/vnc-enc-tight.h +++ b/ui/vnc-enc-tight.h @@ -176,7 +176,6 @@ #define VNC_TIGHT_MAX_SPLIT_TILE_SIZE 16 #define VNC_TIGHT_JPEG_MIN_RECT_SIZE 4096 -#define VNC_TIGHT_PNG_MIN_RECT_SIZE 4096 #define VNC_TIGHT_DETECT_SUBROW_WIDTH 7 #define VNC_TIGHT_DETECT_MIN_WIDTH 8 #define VNC_TIGHT_DETECT_MIN_HEIGHT 8 -- 1.7.1